fix: player Dropping Variant (better codec available) when it should …

…not (#6163) Fixes #6162
shaka-project · Jan 25, 2024 · 07ebdb1 · 07ebdb1
1 parent 65981e2
commit 07ebdb1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/lib/util/stream_utils.js b/lib/util/stream_utils.js
@@ -162,7 +162,7 @@ shaka.util.StreamUtils = class {
           const currentCodec =
             MimeUtils.getNormalizedCodec(stream.codecs);
           if (previousCodec == currentCodec) {
-            if (stream.bandwidth < previousStream.bandwidth) {
+            if (stream.bandwidth > previousStream.bandwidth) {
               validVideoStreams.push(stream);
               validVideoIds.push(stream.id);
             }

diff --git a/test/util/stream_utils_unit.js b/test/util/stream_utils_unit.js
@@ -825,21 +825,15 @@ describe('StreamUtils', () => {
             stream.size(20, 20);
           });
         });
-        manifest.addVariant(6, (variant) => {
-          variant.addVideo(7, (stream) => {
-            stream.bandwidth = 600000;
-            stream.size(20, 20);
-          });
-        });
       });
 
       shaka.util.StreamUtils.chooseCodecsAndFilterManifest(manifest,
           /* preferredVideoCodecs= */[],
           /* preferredAudioCodecs= */[],
           /* preferredDecodingAttributes= */[]);
 
-      expect(manifest.variants.length).toBe(2);
-      expect(manifest.variants.every((v) => [300000, 500000].includes(
+      expect(manifest.variants.length).toBe(3);
+      expect(manifest.variants.every((v) => [300000, 400000, 500000].includes(
           v.video.bandwidth))).toBeTruthy();
     });