Bugfix/offline tutorial sample (#1609)

* Fix tracks sorting in Offline tutorial sample code Sort bandwidths numerically. Fixes #1608
shaka-project · Oct 8, 2018 · 29e15b7 · 29e15b7
1 parent 7c11edd
commit 29e15b7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/AUTHORS b/AUTHORS
@@ -21,6 +21,7 @@ Esteban Dosztal <edosztal@gmail.com>
 Fadomire <fadomire@gmail.com>
 Google Inc. <*@google.com>
 Edgeware AB <*@edgeware.tv>
+Gil Gonen <gil.gonen@gmail.com>
 Giuseppe Samela <giuseppe.samela@gmail.com>
 Itay Kinnrot <Itay.Kinnrot@Kaltura.com>
 Jason Palmer <jason@jason-palmer.com>

diff --git a/CONTRIBUTORS b/CONTRIBUTORS
@@ -34,6 +34,7 @@ Duc Pham <duc.pham@edgeware.tv>
 Esteban Dosztal <edosztal@gmail.com>
 Fadomire <fadomire@gmail.com>
 François Beaufort <fbeaufort@google.com>
+Gil Gonen <gil.gonen@gmail.com>
 Giuseppe Samela <giuseppe.samela@gmail.com>
 Itay Kinnrot <itay.kinnrot@kaltura.com>
 Jacob Trimble <modmaker@google.com>

diff --git a/docs/tutorials/offline.md b/docs/tutorials/offline.md
@@ -135,9 +135,9 @@ function selectTracks(tracks) {
   // Store the highest bandwidth variant.
   var found = tracks
       .filter(function(track) { return track.type == 'variant'; })
-      .sort(function(a, b) { return a.bandwidth > b.bandwidth; })
+      .sort(function(a, b) { return a.bandwidth - b.bandwidth; })
       .pop();
-  console.log('Offline Track: ' + found);
+  console.log('Offline Track bandwidth: ' + found.bandwidth);
   return [ found ];
 }
 
@@ -487,9 +487,9 @@ function selectTracks(tracks) {
   // Store the highest bandwidth variant.
   var found = tracks
       .filter(function(track) { return track.type == 'variant'; })
-      .sort(function(a, b) { return a.bandwidth > b.bandwidth; })
+      .sort(function(a, b) { return a.bandwidth - b.bandwidth; })
       .pop();
-  console.log('Offline Track: ' + found);
+  console.log('Offline Track bandwidth: ' + found.bandwidth);
   return [ found ];
 }