feat(UI): Hide language and resolution overflow menu button if there'…

…s only one choice (#5928) Closes #4720
shaka-project · Nov 27, 2023 · 628bb63 · 628bb63
1 parent 078ab36
commit 628bb63
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/ui/audio_language_selection.js b/ui/audio_language_selection.js
@@ -76,6 +76,9 @@ shaka.ui.AudioLanguageSelection = class extends shaka.ui.SettingsMenu {
         new shaka.util.FakeEvent('languageselectionupdated'));
 
     this.button.setAttribute('shaka-status', this.currentSelection.innerText);
+
+    const numberOfItems = this.menu.getElementsByTagName('button').length;
+    shaka.ui.Utils.setDisplay(this.button, numberOfItems > 2);
   }
 
   /** @private */

diff --git a/ui/resolution_selection.js b/ui/resolution_selection.js
@@ -194,6 +194,8 @@ shaka.ui.ResolutionSelection = class extends shaka.ui.SettingsMenu {
         new shaka.util.FakeEvent('resolutionselectionupdated'));
 
     this.updateLocalizedStrings_();
+
+    shaka.ui.Utils.setDisplay(this.button, tracks.length > 0);
   }