Skip to content

Commit

Permalink
ci: Add overall test timeout of 30 minutes (#6583)
Browse files Browse the repository at this point in the history
When tests occasionally timeout (as is currently happening with
IndexedDB hangs on Mac), we should stop the test run after 30 minutes
and allow the "deflake" workflow to rerun them. Without this timeout,
the test run can takes hours.

A successful test run takes 15-20 minutes currently.
  • Loading branch information
joeyparrish committed May 11, 2024
1 parent 671a943 commit 790cc35
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/build-and-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ jobs:
run: python build/all.py

- name: Test Player
timeout-minutes: 30
shell: bash
run: |
browser=${{ matrix.browser }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/selenium-lab-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ jobs:
# ALLOCATED_PORT must be defined by the self-hosted runner, and mapped
# from the host to the container.
- name: Test Player
timeout-minutes: 30
run: |
# Use of an array keeps elements intact, and allows an element to
# contain spaces without being expanded into multiple arguments in a
Expand Down

0 comments on commit 790cc35

Please sign in to comment.