Skip to content

Commit

Permalink
test: Fix seek range test flake on Safari (#6237)
Browse files Browse the repository at this point in the history
Closes #6227
  • Loading branch information
joeyparrish committed Feb 8, 2024
1 parent 4dc8401 commit 83c02b8
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions test/test/util/waiter.js
Expand Up @@ -184,6 +184,7 @@ shaka.test.Waiter = class {
}
this.eventManager_.unlisten(mediaElement, 'timeupdate');
this.eventManager_.unlisten(mediaElement, 'ended');
this.eventManager_.unlisten(mediaElement, 'durationchange');
};

const p = new Promise((resolve) => {
Expand All @@ -202,6 +203,10 @@ shaka.test.Waiter = class {
timer.tickEvery(/* seconds= */ 1);
this.eventManager_.listen(mediaElement, 'timeupdate', check);
this.eventManager_.listen(mediaElement, 'ended', check);
// Some tests on Safari expose a condition where the ended flag can be
// found in the desired state in a brief window during a durationchange
// event.
this.eventManager_.listen(mediaElement, 'durationchange', check);
});

return this.waitUntilGeneric_(goalName, p, cleanup, mediaElement);
Expand Down

0 comments on commit 83c02b8

Please sign in to comment.