Skip to content

Commit

Permalink
fix(HLS): Fix labelling of captions in Safari (#6426)
Browse files Browse the repository at this point in the history
Fixes #6233
  • Loading branch information
avelad authored and joeyparrish committed May 7, 2024
1 parent cab94f8 commit 9282a1b
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions lib/util/stream_utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -1273,8 +1273,6 @@ shaka.util.StreamUtils = class {
* @return {shaka.extern.Track}
*/
static html5TextTrackToTrack(textTrack) {
const CLOSED_CAPTION_MIMETYPE =
shaka.util.MimeUtils.CEA608_CLOSED_CAPTION_MIMETYPE;
const StreamUtils = shaka.util.StreamUtils;

/** @type {shaka.extern.Track} */
Expand All @@ -1283,7 +1281,8 @@ shaka.util.StreamUtils = class {
track.type = 'text';
track.originalTextId = textTrack.id;
if (textTrack.kind == 'captions') {
track.mimeType = CLOSED_CAPTION_MIMETYPE;
// See: https://github.com/shaka-project/shaka-player/issues/6233
track.mimeType = 'unknown';
}
if (textTrack.kind == 'subtitles') {
track.mimeType = 'text/vtt';
Expand Down

0 comments on commit 9282a1b

Please sign in to comment.