Add new request type TIMING for clock sync requests (#1489)

Fixes #1488
shaka-project · Jul 16, 2018 · e312c3a · e312c3a
1 parent b0a52a6
commit e312c3a
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 2 deletions.
diff --git a/AUTHORS b/AUTHORS
@@ -32,6 +32,7 @@ Mattias Wadman <mattias.wadman@gmail.com>
 Morten Hansen <mimo@mimo-design.com>
 Nick Desaulniers <nick@mozilla.com>
 Oskar Arvidsson <oskar@irock.se>
+Patrick Cruikshank <patrick.cruikshank@gmail.com>
 Patrick Kunka <patrick@kunkalabs.com>
 Philo Inc. <*@philo.com>
 Robert Colantuoni <rgc@colantuoni.com>

diff --git a/CONTRIBUTORS b/CONTRIBUTORS
@@ -54,6 +54,7 @@ Natalie Harris <natalieharris@google.com>
 Nick Desaulniers <nick@mozilla.com>
 Niklas Korz <nk@alugha.com>
 Oskar Arvidsson <oskar@irock.se>
+Patrick Cruikshank <patrick.cruikshank@gmail.com>
 Patrick Kunka <patrick@kunkalabs.com>
 Robert Colantuoni <rgc@colantuoni.com>
 Rohit Makasana <rohitbm@google.com>

diff --git a/lib/dash/dash_parser.js b/lib/dash/dash_parser.js
@@ -1467,7 +1467,7 @@ shaka.dash.DashParser.prototype.requestForTiming_ =
   let request = shaka.net.NetworkingEngine.makeRequest(
       requestUris, this.config_.retryParameters);
   request.method = method;
-  const type = shaka.net.NetworkingEngine.RequestType.MANIFEST;
+  const type = shaka.net.NetworkingEngine.RequestType.TIMING;
 
   let operation = this.playerInterface_.networkingEngine.request(type, request);
   this.operationManager_.manage(operation);

diff --git a/lib/net/networking_engine.js b/lib/net/networking_engine.js
@@ -72,6 +72,7 @@ shaka.net.NetworkingEngine.RequestType = {
   'SEGMENT': 1,
   'LICENSE': 2,
   'APP': 3,
+  'TIMING': 4,
 };
 
 

diff --git a/test/dash/dash_parser_live_unit.js b/test/dash/dash_parser_live_unit.js
@@ -790,7 +790,7 @@ describe('DashParser Live', function() {
 
   describe('stop', function() {
     const manifestRequestType = shaka.net.NetworkingEngine.RequestType.MANIFEST;
-    const dateRequestType = shaka.net.NetworkingEngine.RequestType.MANIFEST;
+    const dateRequestType = shaka.net.NetworkingEngine.RequestType.TIMING;
     const manifestUri = 'dummy://foo';
     const dateUri = 'http://foo.bar/date';