Merge pull request #421 from hochhaus/ver

Update to compiler v20160713
shaka-project · Jul 26, 2016 · efaba56 · efaba56
2 parents 022226c + b7fc078
commit efaba56
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 77 deletions.
diff --git a/build/build.py b/build/build.py
@@ -60,13 +60,6 @@
     # about the old one.
     '--jscomp_off=deprecatedAnnotations',
 
-    # 'analyzerChecks' complains about countless instances of implicitly
-    # nullable types, plus a few other issues.  Even the closure library doesn't
-    # pass these checks, and the implicit nullability check in particular is
-    # over-zealous and unhelpful.  So we disable the whole category of
-    # 'analyzerChecks'.
-    '--jscomp_off=analyzerChecks',
-
     '--extra_annotation_name=listens',
     '--extra_annotation_name=exportDoc',
 
@@ -238,6 +231,7 @@ def build_raw(self, extra_opts):
                        'third_party', 'closure', 'compiler.jar')
     jar = shakaBuildHelpers.cygwin_safe_path(jar)
     files = [shakaBuildHelpers.cygwin_safe_path(f) for f in self.include]
+    files.sort()
 
     try:
       cmd_line = ['java', '-jar', jar] + closure_opts + extra_opts + files

diff --git a/build/check.py b/build/check.py
@@ -131,7 +131,8 @@ def get(*args):
 
   # Ignore missing goog.require since we assume the whole library is
   # already included.
-  opts = ['--jscomp_off=missingRequire', '--checks-only', '-O', 'SIMPLE']
+  opts = ['--jscomp_off=missingRequire', '--jscomp_off=strictMissingRequire',
+          '--checks-only', '-O', 'SIMPLE']
   return test_build.build_raw(opts)
 
 

diff --git a/externs/htmltrackelement.js b/externs/htmltrackelement.js
diff --git a/test/media/drm_engine_integration.js b/test/media/drm_engine_integration.js
@@ -52,8 +52,8 @@ describe('DrmEngine', function() {
     jasmine.DEFAULT_TIMEOUT_INTERVAL = 12000;  // ms
 
     video = /** @type {HTMLVideoElement} */ (document.createElement('video'));
-    video.width = '600';
-    video.height = '400';
+    video.width = 600;
+    video.height = 400;
     video.muted = true;
     document.body.appendChild(video);
 

diff --git a/test/media/media_source_engine_integration.js b/test/media/media_source_engine_integration.js
@@ -57,8 +57,8 @@ describe('MediaSourceEngine', function() {
 
   beforeAll(function(done) {
     video = /** @type {HTMLVideoElement} */ (document.createElement('video'));
-    video.width = '600';
-    video.height = '400';
+    video.width = 600;
+    video.height = 400;
     document.body.appendChild(video);
 
     originalTimeout = jasmine.DEFAULT_TIMEOUT_INTERVAL;

diff --git a/test/media/streaming_engine_integration.js b/test/media/streaming_engine_integration.js
@@ -72,8 +72,8 @@ describe('StreamingEngine', function() {
     jasmine.DEFAULT_TIMEOUT_INTERVAL = 90000;  // ms
 
     video = /** @type {HTMLVideoElement} */ (document.createElement('video'));
-    video.width = '600';
-    video.height = '400';
+    video.width = 600;
+    video.height = 400;
     video.muted = true;
     document.body.appendChild(video);
   });

diff --git a/test/offline/offline_integration.js b/test/offline/offline_integration.js
@@ -25,8 +25,8 @@ describe('Offline', function() {
 
   beforeAll(/** @suppress {accessControls} */ function(done) {
     video = /** @type {!HTMLVideoElement} */ (document.createElement('video'));
-    video.width = '600';
-    video.height = '400';
+    video.width = 600;
+    video.height = 400;
     video.muted = true;
     document.body.appendChild(video);
 

diff --git a/test/player_integration.js b/test/player_integration.js
@@ -33,8 +33,8 @@ describe('Player', function() {
 
   beforeAll(function(done) {
     video = /** @type {!HTMLVideoElement} */ (document.createElement('video'));
-    video.width = '600';
-    video.height = '400';
+    video.width = 600;
+    video.height = 400;
     video.muted = true;
     document.body.appendChild(video);
 

diff --git a/third_party/SUMMARY.txt b/third_party/SUMMARY.txt
@@ -1,6 +1,5 @@
 closure/compiler.jar
-  The closure compiler, v20160208 + patches, by Google.
-  Cherry-picked 3734b26b to remove bogus arguments checks.
+  The closure compiler, v20160713, by Google.
   Apache v2.0 license.
   https://github.com/google/closure-compiler
 

diff --git a/third_party/closure/compiler.jar b/third_party/closure/compiler.jar