Skip to content

Commit

Permalink
fix(demo): Remove max height of demo config tabs (#6324)
Browse files Browse the repository at this point in the history
Each tab in the demo config had a max height of 1000px. That was not a problem previously, but the "streaming" config now has so many config values that it no longer fits into that limit. This PR removes that limit, by instead setting a max-height value of "fit-content".
Unfortunately, doing that seems to break the open/close animation of the tabs, and makes it look kind of bad, so this also removes the animation entirely; it's better to have no animation than an ugly one.
  • Loading branch information
theodab authored and avelad committed Apr 8, 2024
1 parent 2720ba4 commit f18e818
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions demo/demo.less
Expand Up @@ -568,16 +568,12 @@ footer .mdl-mega-footer__link-list {
text-align: left;
opacity: 0;
max-height: 0;
transition: 0.3s ease-in-out;
}

.input-container-style-accordion.show {
opacity: 1;

/* If the max-height is too high (e.g. set to 100%), the "sliding out"
* animation is too fast to make out with the eye.
* So give it a fixed maximum instead. */
max-height: 1000px;
max-height: fit-content;
}

.input-header {
Expand Down

0 comments on commit f18e818

Please sign in to comment.