Skip to content

Commit

Permalink
fix(hisense): set stallSkip to 0 for HiSense devices (#5833)
Browse files Browse the repository at this point in the history
This change fixes an issue on HiSense devices, where playback is
sometimes repeated because current time is updated by skip on devices
which don't support precise seeking

Co-authored-by: Ivan Kohut <ivan.kohut@lamin.ar>
  • Loading branch information
2 people authored and joeyparrish committed Feb 17, 2024
1 parent d55137b commit f78cab4
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions lib/util/player_configuration.js
Expand Up @@ -189,13 +189,15 @@ shaka.util.PlayerConfiguration = class {
parsePrftBox: false,
};

// WebOS, Tizen, and Chromecast have long hardware pipelines that respond
// slowly to seeking. Therefore we should not seek when we detect a stall
// WebOS, Tizen, Chromecast and Hisense have long hardware pipelines
// that respond slowly to seeking.
// Therefore we should not seek when we detect a stall
// on one of these platforms. Instead, default stallSkip to 0 to force the
// stall detector to pause and play instead.
if (shaka.util.Platform.isWebOS() ||
shaka.util.Platform.isTizen() ||
shaka.util.Platform.isChromecast()) {
shaka.util.Platform.isChromecast() ||
shaka.util.Platform.isHisense()) {
streaming.stallSkip = 0;
}

Expand Down

0 comments on commit f78cab4

Please sign in to comment.