Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text parser plugin docs out of date #1046

Closed
hussam-i-am opened this issue Oct 3, 2017 · 2 comments
Closed

Text parser plugin docs out of date #1046

hussam-i-am opened this issue Oct 3, 2017 · 2 comments
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: docs Improvements or fixes to documentation
Milestone
v2.3.0

Comments

@hussam-i-am
Copy link

It looks like the namespace of TextEngine was changed in v2.2 fromshaka.media.TextEngine.registerParser to shaka.text.TextEngine.registerParser. The docs still says shaka.media and there's is no mention of this change in in the upgrade guide.

Commit:
c6c6d05#diff-3b4369b30c3ae2bbec5bd1048456ba71R91

Docs:
https://shaka-player-demo.appspot.com/docs/api/tutorial-upgrade-v2-1.html
https://shaka-player-demo.appspot.com/docs/api/tutorial-plugins.html
@joeyparrish joeyparrish added the type: docs Improvements or fixes to documentation label Oct 3, 2017
@joeyparrish joeyparrish added this to the v2.3.0 milestone Oct 3, 2017
@joeyparrish
Copy link
Member

Good catch! I'm sorry we made that mistake. We will update the docs and get the fix out in v2.2.3.

@joeyparrish joeyparrish self-assigned this Oct 3, 2017
@joeyparrish
Copy link
Member

Cherry-picked to v2.2.3.

joeyparrish added a commit that referenced this issue Oct 16, 2017
@joeyparrish
Update docs with regard to text namespace
38978a0 
We moved TextEngine to a new namespace between v2.1 and v2.2, but
forgot to update the relevant docs.

Closes #1046

Change-Id: Ifddbe03931b2e76cc4778aaa4c3c70695a2dce62
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: docs Improvements or fixes to documentation
Projects
None yet
Milestone
v2.3.0
Development

No branches or pull requests
3 participants
@hussam-i-am @joeyparrish @shaka-bot