Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop fetching live stream while paused #2 #1121

Closed
kuznetcoff777 opened this issue Nov 14, 2017 · 4 comments
Closed

Stop fetching live stream while paused #2 #1121

kuznetcoff777 opened this issue Nov 14, 2017 · 4 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@kuznetcoff777
Copy link

Have you read the FAQ and checked for duplicate issues: yes

What version of Shaka Player are you using: 2.2.5-debug

Can you reproduce the issue with our latest release version: yes

Can you reproduce the issue with the latest code from master: yes

Are you using the demo app or your own custom app:demo

If custom app, can you reproduce the issue using our demo app:

What browser and OS are you using: win7x64+chrome

What are the manifest and license server URIs: vm2.dashif.org/livesim/utc_head/testpic_6s/Manifest.mpd
(you can send the URIs to shaka-player-issues@google.com instead, but please use GitHub and the template for the rest)

What did you do? Opened stream https://shaka-player-demo.appspot.com/demo/#asset=//vm2.dashif.org/livesim/utc_head/testpic_6s/Manifest.mpd;lang=ru
Paused it and waited for >5 minutes

What did you expect to happen? Player will not fetch segments when paused even after >5 minutes (up to timeShiftBufferDepth="PT5M")

What actually happened? Palyer still feteches segments after > 5 minutes of being paused

P.s. the same issue #982 - must be fixed , but in fact it is not.

@vaage vaage added needs triage type: bug Something isn't working correctly and removed needs triage labels Nov 14, 2017
@kuznetcoff777
Copy link
Author

Guys, hi! Will it be fixed in 2.3.0?

@michellezhuogg michellezhuogg self-assigned this Nov 20, 2017
@joeyparrish joeyparrish added this to the v2.3.0 milestone Nov 22, 2017
@joeyparrish
Copy link
Member

Yes, I'm sure it will. We have identified the cause and will have a fix out in the near future.

@joeyparrish
Copy link
Member

The fix has been cherry-picked for v2.2.7.

joeyparrish pushed a commit that referenced this issue Nov 28, 2017
We shall not buffer live stream, when the video is paused and the
playhead falls out of the seek range.

Closes #1121.

Change-Id: I66bbe1e62017f6ae8d121f072f324763f73da0f4
@kuznetcoff777
Copy link
Author

Confirm, thanks!

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

5 participants