Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angel One HLS asset failures #1137

Closed
theodab opened this issue Nov 17, 2017 · 4 comments
Closed

Angel One HLS asset failures #1137

theodab opened this issue Nov 17, 2017 · 4 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@theodab
Copy link
Collaborator

theodab commented Nov 17, 2017

On the nightly, the Angel One HLS assets are both behaving incorrectly.
The clear one seems to infer the start time as being ~8.5 seconds before the real start time, which results in there being a large gap at the start of the video.
In a possibly-related note, the Widevine-encrypted version outputs a BUFFER_READ_OUT_OF_BOUNDS error with the following stack trace:

Error: Shaka Error MEDIA.BUFFER_READ_OUT_OF_BOUNDS ()
    at new shaka.util.Error (https://nightly-dot-shaka-player-demo.appspot.com/lib/util/error.js:72:13)
    at shaka.util.DataViewReader.throwOutOfBounds_ (https://nightly-dot-shaka-player-demo.appspot.com/lib/util/data_view_reader.js:288:9)
    at shaka.util.DataViewReader.skip (https://nightly-dot-shaka-player-demo.appspot.com/lib/util/data_view_reader.js:223:10)
    at shaka.util.Mp4Parser.parseNext (https://nightly-dot-shaka-player-demo.appspot.com/lib/util/mp4_parser.js:236:12)
    at shaka.util.Mp4Parser.parse (https://nightly-dot-shaka-player-demo.appspot.com/lib/util/mp4_parser.js:161:10)
    at shaka.hls.HlsParser.getStartTimeFromMp4Segment_ (https://nightly-dot-shaka-player-demo.appspot.com/lib/hls/hls_parser.js:1348:10)
    at shaka.hls.HlsParser.<anonymous> (https://nightly-dot-shaka-player-demo.appspot.com/lib/hls/hls_parser.js:1304:19)
    at <anonymous>

This only happens on the nightly, so it's probably the result of a recent CL; we've had a number that have to do with time offset in HLS recently, so I'm not sure which.

@theodab theodab added the type: bug Something isn't working correctly label Nov 17, 2017
@TheModMaker
Copy link
Contributor

The clear asset hasn't played since we added Live support in 113d974.
The encrypted asset hasn't played since we added partial segment requests in a93455a.

@TheModMaker TheModMaker added this to the v2.3.0 milestone Nov 20, 2017
@joeyparrish joeyparrish changed the title Angel One HLS assets have incorrect start time Angel One HLS asset failures Nov 20, 2017
@joeyparrish
Copy link
Member

The encrypted version is failing, too. I'm looking into it.

@joeyparrish joeyparrish self-assigned this Nov 20, 2017
@joeyparrish
Copy link
Member

The encrypted version fails because we aren't fetching enough of the segments to find the tfdt box and extract the timestamp.

The clear version fails because the text stream starts at 0 and the video & audio streams start at 8+change, so the HLS parser sets presentationTimeOffset to 0.

shaka-bot pushed a commit that referenced this issue Nov 21, 2017
This increases the amount of data we fetch to get HLS segment start
times.  The presence of a large PSSH box in Widevine-encrypted content
was pushing the "tfdt" box past the 1kB mark, so we will now fetch
2kB.

Issue #1137
References FR in shaka-project/shaka-packager#294

Change-Id: I51a1407c4d992e42d07c3e6c6c501051100d1620
@joeyparrish
Copy link
Member

Fix cherry-picked for v2.2.7.

joeyparrish added a commit that referenced this issue Nov 27, 2017
The version encoded by Apple had serious issues with timestamps
misaligned between video and text.  The asset has been re-encoded and
re-packaged using Shaka Packager.

Closes #1137

Change-Id: Ie2ae620d79c7f7611810b558e9a05884a54535bf
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants