-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure() shouldn't switch tracks unless needed #1138
Comments
@kocoten1992 Are you manually calling I believe the fact it only happens on 1080p is a red herring. I can reproduce something similar during startup on 1080p, but not after a bit of playback. I think the problem is that the demo app calls When someone calls |
@TheModMaker thank for the word 'red herring' (new word), I've create snippet serve at backup and easier debug for this problem http://jsbin.com/veginugace/edit?html,console,output (On this snippet, change between |
yep, that exactly what happen, when I tried to call
It will trigger I think I'll fix the demo, I want the badge contributor 😄, the fix gonna be like: // from
shakaPlayer.configure({abr: {enabled: false}})
// to
if (shakaPlayer.getConfiguration().abr.enabled) {
shakaPlayer.configure({abr: {enabled: false}})
} |
P/s: but should we guard again this, I think this is a trap, at first use, I didn't know call configure would mess with selectVariantTrack at all P/s: On the other hand, if dev try the demo and find out result diff from their, they will dig up the demo, so maybe not needed to guard.........? |
Thanks for the offer to fix, but that would not be the preferred fix. An app should be able to call |
Configure should only switch tracks if the current variant can't be played under the new configuration. Closes #1138 Change-Id: I1acb8bdbb0c8b41252e978bd17ef52bec1095844
Fix cherry-picked for v2.2.8. |
Have you read the FAQ and checked for duplicate issues: yes (with keywork
buffer
andswitch
)What version of Shaka Player are you using: on the demo
Can you reproduce the issue with our latest release version: yes
Can you reproduce the issue with the latest code from
master
: not try yetAre you using the demo app or your own custom app: in both your demo and my app
What browser and OS are you using: Chrome, ubuntu 17.10
What did you do? (there is a snippet on comment below)
256x110
and1920x818
, just do it normally, nothing special here, like256x110
and wait for it to play1920x818
and wait for it to play256x110
and wait for it to play... (repeat as many times as needed until you see the bug, less than 5 times in average case, 15 at most)
What did you expect to happen?
true
) should clear current buffer, video pause briefly and new resolution apply immediatelyWhat actually happened?
1920x818
, calling256x110
always work.256x110
, calling1920x818
doesn't always work.It happen in my application as well, it worth notice this: my app have 5 resolution:
1080
,720
,480
,360
,240
, calling for 720 or less work, just 1080 doesn't workI set streaming bufferGoal 120s which mean, I have to endure 120s of lower resolution until it actually switch to
1080
The text was updated successfully, but these errors were encountered: