Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live stream doesn't play on Chromecast #1149

Closed
shaygolan01 opened this issue Nov 22, 2017 · 5 comments
Closed

Live stream doesn't play on Chromecast #1149

shaygolan01 opened this issue Nov 22, 2017 · 5 comments
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@shaygolan01
Copy link

shaygolan01 commented Nov 22, 2017

Have you read the FAQ and checked for duplicate issues: Yes

What version of Shaka Player are you using: 2.2.6

Can you reproduce the issue with our latest release version: Yes

Can you reproduce the issue with the latest code from master: Yes

Are you using the demo app or your own custom app: Custom app

If custom app, can you reproduce the issue using our demo app:

What browser and OS are you using: Chromecast Ultra and gen2

What are the manifest and license server URIs:
https://dfwlive-sponsored.akamaized.net/Content/DASH.abre/Live/channel(BBCAHD-6053.dfw.1080.mobile)/manifest.mpd
(the content is DRM protected and I cannot supply the license for it)

What did you do?
Loaded the live content.

What did you expect to happen?
Stream begins to play after a couple of seconds of requesting video and audio data.

What actually happened?
Stream doesn't play, though I see video and audio downloading.

This issue started after bug fix #1061
It seems that our manifest imposes a 'video.seeking' and 'video.paused' on the first attempt to set the play head position, that prevents shaka.media.Playhead.prototype.onPollGapJump_ completing.
See playhead.js onPollGapJump_ function

@TheModMaker
Copy link
Contributor

Without a license server URL, we can't reproduce the problem. You can send the URL privately to shaka-player-issues@google.com if you like. I can play all our live and protected content fine on Chromecast, so we need to be able to play your content to see any issue.

@TheModMaker TheModMaker added needs triage status: waiting on response Waiting on a response from the reporter(s) of the issue labels Nov 22, 2017
shaka-bot pushed a commit that referenced this issue Nov 22, 2017
This also changes the tests so they mirror the |video.seeking|
property to reveal the problem that change created.  That change
broke seeking into gaps and gaps before the start.

Issue #1149
Issue #1150
Reopens #1061

Change-Id: I18fb65b1529acdacd0becd77078780625e0a955b
@TheModMaker
Copy link
Contributor

We just reverted the fix for #1061. Can you test again to see if that fixes it? You can use the nightly, but be sure to clear the cache and check the version starts with v2.2.0 followed by a number that is at least 133:

https://nightly-dot-shaka-player-demo.appspot.com/demo/

@shaygolan01
Copy link
Author

Thank you for understanding the license issue.
I tested the reverted fix #1061 and our live stream still doesn't play.
On v2.2.2 the live stream plays fine.
It seem that another change for #982, this fix if (this.video_.paused) return; has the same effect as if (this.video_.seeking) return;
Only removing both lines enables the stream to start playing.

I understand that these fixes are for issues occurring during playback, maybe a condition allowing to ignore these lines only on playback start is a suitable fix for our issue?

@shaygolan01 shaygolan01 reopened this Nov 24, 2017
@joeyparrish joeyparrish removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Nov 27, 2017
@joeyparrish
Copy link
Member

We should retest this once v2.2.7 is out. We have fixed a few issues lately that might be related: #1105, #1150. When those fixes are in the demo receiver, we should see if those fixes help at all.

joeyparrish pushed a commit that referenced this issue Nov 27, 2017
This also changes the tests so they mirror the |video.seeking|
property to reveal the problem that change created.  That change
broke seeking into gaps and gaps before the start.

Issue #1149
Issue #1150
Reopens #1061

Change-Id: I18fb65b1529acdacd0becd77078780625e0a955b
@shaygolan01
Copy link
Author

Tested with 2.2.7 Our live streams are playing.

@joeyparrish joeyparrish added this to the v2.3.0 milestone Nov 29, 2017
@joeyparrish joeyparrish added type: bug Something isn't working correctly and removed needs triage labels Nov 29, 2017
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants