Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar in cast dialogue has incorrect duration. #1174

Closed
theodab opened this issue Dec 7, 2017 · 5 comments
Closed

Progress bar in cast dialogue has incorrect duration. #1174

theodab opened this issue Dec 7, 2017 · 5 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@theodab
Copy link
Collaborator

theodab commented Dec 7, 2017

screen shot 2017-12-07 at 1 35 16 pm

The currentTime property is being synchronized properly, but the duration does not seem to be.

@theodab theodab added the type: bug Something isn't working correctly label Dec 7, 2017
@joeyparrish joeyparrish added this to the v2.4.0 milestone Dec 7, 2017
@theodab
Copy link
Collaborator Author

theodab commented Jan 11, 2018

Looking over Chromecast docs on media playback messages, it looks like current time is synchronized by MediaStatus messages, which we emit. Duration, on the other hand, is handled by MediaInformation messages, which we do not. That would explain why the dialogue has a current time, but not a duration.

As far as I can tell, however, MediaInformation messages are supposed to be sent by the sender as part of the process of loading the media? We load media through our own pipeline, so we don't make use of castSession.loadMedia. And I don't know if you can just send a MediaInformation message on it's own, solely to set duration.

You can include a MediaInformation message as part of the MediaStatus block, but that is meant to be a signal that the asset playing has changed on the receiver's end, so it would probably be improper to use it to set duration.

@theodab theodab self-assigned this Jan 17, 2018
@theodab
Copy link
Collaborator Author

theodab commented Jan 19, 2018

Note that this change will need to be in the cast receiver to work, so it won't show up until we upload a new version of the receiver.

joeyparrish pushed a commit that referenced this issue Jan 19, 2018
When casting, the cast dialogue contains information about the current
media, including volume, time, and duration. These values are
synchronized by different messages. We were sending over the
MediaStatus messages that synchronize current time, but were not
including duration in our MediaInfo messages. This caused the cast
dialogue progress bar to not display correctly.
This change makes it so that our MediaInfo messages now include
duration, and we now send over MediaInfo messages in situations where
we did not previously.

Closes #1174

Change-Id: Ic585f3befec9e44ef4e9895d04ddfad6cc5473b3
@joeyparrish
Copy link
Member

Cherry-picked to v2.3.1.

joeyparrish pushed a commit that referenced this issue Jan 19, 2018
When casting, the cast dialogue contains information about the current
media, including volume, time, and duration. These values are
synchronized by different messages. We were sending over the
MediaStatus messages that synchronize current time, but were not
including duration in our MediaInfo messages. This caused the cast
dialogue progress bar to not display correctly.
This change makes it so that our MediaInfo messages now include
duration, and we now send over MediaInfo messages in situations where
we did not previously.

Closes #1174

Change-Id: Ic585f3befec9e44ef4e9895d04ddfad6cc5473b3
@joeyparrish
Copy link
Member

Cherry-picked for v2.2.10.

@joeyparrish
Copy link
Member

The cast receiver has been updated for v2.2.10 and v2.3.1.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants