-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress bar in cast dialogue has incorrect duration. #1174
Comments
Looking over Chromecast docs on media playback messages, it looks like current time is synchronized by MediaStatus messages, which we emit. Duration, on the other hand, is handled by MediaInformation messages, which we do not. That would explain why the dialogue has a current time, but not a duration. As far as I can tell, however, MediaInformation messages are supposed to be sent by the sender as part of the process of loading the media? We load media through our own pipeline, so we don't make use of castSession.loadMedia. And I don't know if you can just send a MediaInformation message on it's own, solely to set duration. You can include a MediaInformation message as part of the MediaStatus block, but that is meant to be a signal that the asset playing has changed on the receiver's end, so it would probably be improper to use it to set duration. |
Note that this change will need to be in the cast receiver to work, so it won't show up until we upload a new version of the receiver. |
When casting, the cast dialogue contains information about the current media, including volume, time, and duration. These values are synchronized by different messages. We were sending over the MediaStatus messages that synchronize current time, but were not including duration in our MediaInfo messages. This caused the cast dialogue progress bar to not display correctly. This change makes it so that our MediaInfo messages now include duration, and we now send over MediaInfo messages in situations where we did not previously. Closes #1174 Change-Id: Ic585f3befec9e44ef4e9895d04ddfad6cc5473b3
Cherry-picked to v2.3.1. |
When casting, the cast dialogue contains information about the current media, including volume, time, and duration. These values are synchronized by different messages. We were sending over the MediaStatus messages that synchronize current time, but were not including duration in our MediaInfo messages. This caused the cast dialogue progress bar to not display correctly. This change makes it so that our MediaInfo messages now include duration, and we now send over MediaInfo messages in situations where we did not previously. Closes #1174 Change-Id: Ic585f3befec9e44ef4e9895d04ddfad6cc5473b3
Cherry-picked for v2.2.10. |
The cast receiver has been updated for v2.2.10 and v2.3.1. |
The currentTime property is being synchronized properly, but the duration does not seem to be.
The text was updated successfully, but these errors were encountered: