Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to override timeShift value in dash live stream through the config #1177

Closed
amity177 opened this issue Dec 8, 2017 · 5 comments
Closed

Allow user to override timeShift value in dash live stream through the config #1177

amity177 opened this issue Dec 8, 2017 · 5 comments
Assignees
@theodab
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
Tracks & manifest refactor
Milestone
v2.5

Comments

@amity177
Copy link

amity177 commented Dec 8, 2017

Have you read the FAQ and checked for duplicate issues:

What version of Shaka Player are you using:

Can you reproduce the issue with our latest release version:

Can you reproduce the issue with the latest code from master:

Are you using the demo app or your own custom app:

If custom app, can you reproduce the issue using our demo app:

What browser and OS are you using:

What are the manifest and license server URIs:
(you can send the URIs to shaka-player-issues@google.com instead, but please use GitHub and the template for the rest)

What did you do?

What did you expect to happen?

What actually happened?
@TheModMaker
Copy link
Contributor

Are you talking about the timeShiftBufferDepth attribute? That attribute specifies how long the content is alive on the server. If you tried to make it longer, we may not be able to download the segments because the segments no longer exist on the server. We could add a way to reduce the size similar to the seek range but for live.

@TheModMaker TheModMaker added the type: enhancement New feature or request label Dec 9, 2017
@TheModMaker TheModMaker added this to the Backlog milestone Dec 9, 2017
@joeyparrish joeyparrish modified the milestones: Backlog, v2.5 Mar 4, 2018
@theodab theodab self-assigned this Mar 28, 2018
@theodab theodab moved this from Actionable to In progress in Tracks & manifest refactor Jul 11, 2018
Tracks & manifest refactor automation moved this from In progress to Done Jul 16, 2018
@joeyparrish
Copy link
Member

I think this feature is not working correctly. I will reopen and investigate.

@joeyparrish joeyparrish reopened this Jul 20, 2018
Tracks & manifest refactor automation moved this from Done to In progress Jul 20, 2018
@joeyparrish
Copy link
Member

The override set by the player after the initial manifest is parsed is wiped when a live manifest is updated.

@theodab
Copy link
Collaborator

theodab commented Jul 20, 2018

Huh. But only on DASH. Well, that explains why I didn't notice, I was mostly testing with HLS.
I'll look into it.

@joeyparrish
Copy link
Member

No need, I'm already putting together the CL.

@joeyparrish joeyparrish mentioned this issue Jul 20, 2018
Closed
Tracks & manifest refactor automation moved this from In progress to Done Jul 20, 2018
joeyparrish pushed a commit that referenced this issue Aug 6, 2018
@theodab @joeyparrish
Add availabilityWindowOverride configuration.
b0d05e4 
This config lets you override the availability window of a live stream.
It is in config.manifest, and passed along on start.
This will let users configure the parser so that they can seek with HLS
live streams, for example.

Closes #1177
Closes #1307

Change-Id: Icd3c1d81c6b52ebdbb72137df42fc91cd73a0207
joeyparrish added a commit that referenced this issue Aug 6, 2018
@joeyparrish
Move availabilityWindowOverride to manifest parsers
ec33137 
This reverts the implementation to an earlier draft state.  During
review of the first version, I recommended moving the implementation
to Player so that it would be independent of the manifest parsers.
That was bad advice on my part, because this overlooked updates made
by the parsers when live manifests are updated later.

Closes #1177
Closes #1307

Change-Id: I4611e00824dead83c6467da04a2a11afa892ace7
@shaka-project shaka-project locked and limited conversation to collaborators Sep 18, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@theodab theodab

Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
No open projects
Tracks & manifest refactor
  
Done
Milestone
v2.5
Development

No branches or pull requests
5 participants
@TheModMaker @amity177 @joeyparrish @shaka-bot @theodab