-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to override timeShift value in dash live stream through the config #1177
Comments
Are you talking about the |
I think this feature is not working correctly. I will reopen and investigate. |
The override set by the player after the initial manifest is parsed is wiped when a live manifest is updated. |
Huh. But only on DASH. Well, that explains why I didn't notice, I was mostly testing with HLS. |
No need, I'm already putting together the CL. |
This config lets you override the availability window of a live stream. It is in config.manifest, and passed along on start. This will let users configure the parser so that they can seek with HLS live streams, for example. Closes #1177 Closes #1307 Change-Id: Icd3c1d81c6b52ebdbb72137df42fc91cd73a0207
This reverts the implementation to an earlier draft state. During review of the first version, I recommended moving the implementation to Player so that it would be independent of the manifest parsers. That was bad advice on my part, because this overlooked updates made by the parsers when live manifests are updated later. Closes #1177 Closes #1307 Change-Id: I4611e00824dead83c6467da04a2a11afa892ace7
Have you read the FAQ and checked for duplicate issues:
What version of Shaka Player are you using:
Can you reproduce the issue with our latest release version:
Can you reproduce the issue with the latest code from
master
:Are you using the demo app or your own custom app:
If custom app, can you reproduce the issue using our demo app:
What browser and OS are you using:
What are the manifest and license server URIs:
(you can send the URIs to shaka-player-issues@google.com instead, but please use GitHub and the template for the rest)
What did you do?
What did you expect to happen?
What actually happened?
The text was updated successfully, but these errors were encountered: