Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing audio languages should clear the buffer #119

Closed
joeyparrish opened this issue Jul 7, 2015 · 0 comments
Closed

Changing audio languages should clear the buffer #119

joeyparrish opened this issue Jul 7, 2015 · 0 comments
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly

Comments

@joeyparrish
Copy link
Member

When changing audio languages in the test app, either manually or with the "cycle audio track" feature, the old data is retained in buffer.

To reproduce, start playback of "Angel One" in English. After 10 seconds, switch audio tracks to Spanish. Play for a while, then seek back to the beginning. The first few segments will be played in English, in spite of the fact that the language is currently set to Spanish.

This is partly a bug in the test app, and partly a bug in the selectAudioTrack API, which should allow the audio buffer to be cleared.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jul 7, 2015
@joeyparrish joeyparrish self-assigned this Jul 7, 2015
@joeyparrish joeyparrish added this to the v1.5.0 milestone Jul 10, 2015
@joeyparrish joeyparrish removed their assignment Jul 14, 2015
@tdrews tdrews removed this from the v1.5.0 milestone Jul 15, 2015
@tdrews tdrews self-assigned this Jul 15, 2015
@tdrews tdrews closed this as completed in 89d0ef5 Jul 20, 2015
tdrews pushed a commit that referenced this issue Jul 31, 2015
Clear the buffer when switching audio streams.
39f908d 
* Add an optional parameter to Player.selectAudioTrack to clear
  the buffer like selectVideoTrack.

Closes #119

Change-Id: I40c4c1969115826890fe9719a988315b51e5b28c
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TheModMaker @joeyparrish @tdrews @shaka-bot