Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog dates #1263

Closed
nocarryr opened this issue Jan 31, 2018 · 4 comments
Closed

Changelog dates #1263

nocarryr opened this issue Jan 31, 2018 · 4 comments
Assignees
@vaage
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly

Comments

@nocarryr
Copy link
Contributor

The two most recent additions to CHANGELOG.md seem to have the wrong year:
2.3.1 and 2.2.10

Seems a bit "nit-picky", but could be a point of confusion.
@nocarryr nocarryr mentioned this issue Jan 31, 2018
Merged
@vaage vaage self-assigned this Jan 31, 2018
@vaage
Copy link
Contributor

vaage commented Jan 31, 2018

@nocarryr Thanks for finding that. We appreciate the attention to detail.

@vaage vaage added the type: bug Something isn't working correctly label Jan 31, 2018
@vaage vaage closed this as completed in c0a1c39 Jan 31, 2018
@nocarryr
Copy link
Contributor Author

👍

@vaage Thanks for helping to make shaka-player such a great product!

@joeyparrish
Copy link
Member

Thanks! I have updated the corresponding text on the github releases page: https://github.com/google/shaka-player/releases/tag/v2.2.10 https://github.com/google/shaka-player/releases/tag/v2.3.1

@joeyparrish
Copy link
Member

Cherry-picked to v2.3.2

joeyparrish pushed a commit that referenced this issue Feb 1, 2018
@nocarryr @joeyparrish
Fix Wrong Year in CHANGELOG
a063f6c 
Fix Wrong Year in CHANGELOG

It looks like 2017 was such a great year for Shaka Player
that we did not want it to end, so in our CHANGELOG we
decided to start 2017 all over again.

This change updated the two entries to say 2018 instead of
2017.

Backported to v2.3.x

Closes #1263
@shaka-project shaka-project locked and limited conversation to collaborators Apr 2, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vaage vaage

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nocarryr @joeyparrish @shaka-bot @vaage