Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS: use video duration instead of using text duration #1271

Closed
kqyang opened this issue Feb 3, 2018 · 2 comments
Closed

HLS: use video duration instead of using text duration #1271

kqyang opened this issue Feb 3, 2018 · 2 comments
Assignees
Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@kqyang
Copy link
Contributor

kqyang commented Feb 3, 2018

NOTE: For bugs, if you delete this template, we will send it again and ask you to fill it out.

Have you read the FAQ and checked for duplicate open issues?:

Yes.

What version of Shaka Player are you using?:

Latest public demo.

Can you reproduce the issue with our latest release version?:

Yes.

Can you reproduce the issue with the latest code from master?:

Yes.

Are you using the demo app or your own custom app?:

Demo app.

If custom app, can you reproduce the issue using our demo app?:

What browser and OS are you using?:

Chrome on Linux.

What are the manifest and license server URIs?:
(NOTE: you can send the URIs to shaka-player-issues@google.com instead, but please use GitHub and the template for the rest)
(NOTE: a copy of the manifest text or an attached manifest will not be enough to reproduce your issue, and we will ask you to send a URI instead)

https://storage.googleapis.com/wvtemp/kqyang/vtt6/bunny_vtt_master.m3u8

What did you do?

https://shaka-player-demo.appspot.com/demo/#asset=https://storage.googleapis.com/wvtemp/kqyang/vtt6/bunny_vtt_master.m3u8;lang=en-US;build=uncompiled

What did you expect to happen?

Total duration should be around 60 seconds. See the equivalent manifest in DASH, which is handled properly: https://shaka-player-demo.appspot.com/demo/#asset=https://storage.googleapis.com/wvtemp/kqyang/vtt6/bunny.mpd;lang=en-US;build=uncompiled.

What actually happened?

The total duration is about 10 seconds, which is based on the text duration.

v2.1.9 seems to work.

@TheModMaker
Copy link
Contributor

Yep, looks like a bug. Should be easy to fix, we just need to ignore text tracks when calculating the min stream duration.

@TheModMaker TheModMaker added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format labels Feb 3, 2018
@TheModMaker TheModMaker self-assigned this Feb 3, 2018
@TheModMaker TheModMaker added this to the v2.4.0 milestone Feb 3, 2018
joeyparrish pushed a commit that referenced this issue Feb 12, 2018
Closes #1271

Change-Id: Ia17f43d032c9a277e0c3fe0a8568f2b3abf529c5
@joeyparrish
Copy link
Member

Cherry-picked for v2.3.3.

@shaka-project shaka-project locked and limited conversation to collaborators Apr 8, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants