Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pausing does not work with a negative playback rate #130

Closed
gonemad opened this issue Jul 20, 2015 · 3 comments
Closed

Pausing does not work with a negative playback rate #130

gonemad opened this issue Jul 20, 2015 · 3 comments
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v1.5.0

Comments

@gonemad
Copy link

gonemad commented Jul 20, 2015

This is reproducible on the test page http://shaka-player-demo.appspot.com/

Load a video with trick play enabled. Press the rewind button and then hit the pause button. The video will continue to rewind.
@tdrews tdrews added the type: bug Something isn't working correctly label Jul 20, 2015
@tdrews
Copy link
Contributor

tdrews commented Jul 21, 2015

Thanks for the report. We'll take a look.

natalieharris added a commit that referenced this issue Jul 31, 2015
@natalieharris
Update fast-forward and rewind to work with play/pause.
8c62506 
Closes #130.

Change-Id: I33ed2e2ac0014eb3b271f72904996d669b0f13ee
@gonemad
Copy link
Author

gonemad commented Sep 11, 2015

Just to let you know this bug is still present in 1.4.2. The test page shows the behavior as well

@tdrews
Copy link
Contributor

tdrews commented Sep 11, 2015

Thanks. I believe this issue should be fixed in 1.4.1. The regression is most likely from bc7b826.

@tdrews tdrews reopened this Sep 11, 2015
@tdrews tdrews assigned tdrews and unassigned natalieharris Sep 11, 2015
@tdrews tdrews added this to the v1.5.0 milestone Sep 11, 2015
@tdrews tdrews closed this as completed in 6049d67 Sep 11, 2015
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
5 participants
@gonemad @TheModMaker @tdrews @natalieharris @shaka-bot