Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaka silently fails time synchronization if time server returns timestamp that cannot be parsed #1317

Closed
TheJohnBowers opened this issue Feb 24, 2018 · 3 comments
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@TheJohnBowers
Copy link
Contributor

TheJohnBowers commented Feb 24, 2018

Have you read the FAQ and checked for duplicate open issues?:
Yes
What version of Shaka Player are you using?:
Master
Can you reproduce the issue with our latest release version?:
I didn't try it, I figure master is current enough.
Can you reproduce the issue with the latest code from master?:
Yes
Are you using the demo app or your own custom app?:
Demo App
If custom app, can you reproduce the issue using our demo app?:

What browser and OS are you using?:
Chrome
What are the manifest and license server URIs?:
'https://content-duswqa1.downlynk.com/channel/0da2e2615f6a413f9717d6a27859eb63.mpd'

What did you do?
My time server wasn't exposing the 'date' header, so it wasn't there when shaka did the time synchronization.

What did you expect to happen?
If the UTCTiming element is completely missing, shaka warns about that. If it isn't missing, but just returns unparseable data then there is no warning.

What actually happened?
Silent failure to timesync

@joeyparrish
Copy link
Member

@TheJohnBowers, this fails to play for me at all. What particular commit of Shaka Player are you using?

@joeyparrish joeyparrish added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Feb 26, 2018
@joeyparrish
Copy link
Member

I'm getting failed assertions in StreamingEngine with the content you linked to.

joeyparrish pushed a commit that referenced this issue Mar 1, 2018
@joeyparrish
Copy link
Member

Cherry-picked for v2.3.3.

@joeyparrish joeyparrish added type: bug Something isn't working correctly and removed status: waiting on response Waiting on a response from the reporter(s) of the issue needs triage labels Mar 1, 2018
@joeyparrish joeyparrish added this to the v2.4.0 milestone Mar 1, 2018
@shaka-project shaka-project locked and limited conversation to collaborators Apr 27, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants