Native controls can hide/show captions, but not start them streaming #1332
Labels
flag: Why didn't we catch this sooner
This issue is embarassing; we may still need an automated test that could have prevented this issue
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Have you read the FAQ and checked for duplicate open issues?: Yes
What version of Shaka Player are you using?: v2.3.3
Can you reproduce the issue with our latest release version?: yes
Can you reproduce the issue with the latest code from
master
?: yesAre you using the demo app or your own custom app?: demo
What browser and OS are you using?: Chrome 64 Linux
What did you do?
What did you expect to happen? Captions show
What actually happened? Captions are "shown", but no cues exist because we aren't streaming them.
Present in v2.3.0, but not v2.2.10. I suspect this started with the implementation of #1058.
We no longer stream text content until the user asks us to show it, but that is connected through
player.setTextTrackVisibility()
, which is only called by custom controls. The captions button in the native video controls will show/hide captions, but not trigger the player to stream them.The text was updated successfully, but these errors were encountered: