Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native controls can hide/show captions, but not start them streaming #1332

Closed
joeyparrish opened this issue Mar 2, 2018 · 3 comments
Closed
Assignees
Labels
flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?: Yes

What version of Shaka Player are you using?: v2.3.3

Can you reproduce the issue with our latest release version?: yes

Can you reproduce the issue with the latest code from master?: yes

Are you using the demo app or your own custom app?: demo

What browser and OS are you using?: Chrome 64 Linux

What did you do?

  1. Open https://shaka-player-demo.appspot.com/demo/#asset=//storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd;lang=en-US;nativecontrols;build=uncompiled
  2. Try to enable captions using the native video controls

What did you expect to happen? Captions show

What actually happened? Captions are "shown", but no cues exist because we aren't streaming them.

Present in v2.3.0, but not v2.2.10. I suspect this started with the implementation of #1058.

We no longer stream text content until the user asks us to show it, but that is connected through player.setTextTrackVisibility(), which is only called by custom controls. The captions button in the native video controls will show/hide captions, but not trigger the player to stream them.

@joeyparrish joeyparrish added type: bug Something isn't working correctly flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue labels Mar 2, 2018
@joeyparrish joeyparrish added this to the v2.4.0 milestone Mar 2, 2018
@joeyparrish
Copy link
Member Author

There does not appear to be an event to tell us when the native controls have been used to change the text track mode: https://html.spec.whatwg.org/multipage/media.html#texttrack

Perhaps we could add a configuration option, such that if enabled, we would stream regardless of text track state, as we used to do. With this option enabled, native controls could be used with text. Our demo app could set this option when native controls are toggled in the UI.

@joeyparrish
Copy link
Member Author

joeyparrish commented Mar 15, 2018

I think I closed this too soon. The new configuration still needs to be used by the demo app.

@joeyparrish joeyparrish reopened this Mar 15, 2018
joeyparrish added a commit that referenced this issue Mar 21, 2018
This will allow text streaming to work correctly with browser native
controls.

Closes #1332

Change-Id: If11ba67957babad8dea23759aab9004d891aaf6b
joeyparrish added a commit that referenced this issue Mar 21, 2018
Closes #1332

Change-Id: If57c77202db8f4b2132adc24d26d8fffcad6fa69
@joeyparrish
Copy link
Member Author

Cherry-picked for v2.3.4.

@shaka-project shaka-project locked and limited conversation to collaborators May 15, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

2 participants