Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS subtitles #146

Closed
tdrews opened this issue Aug 4, 2015 · 2 comments
Closed

HLS subtitles #146

tdrews opened this issue Aug 4, 2015 · 2 comments
Labels
status: archived Archived and locked; will not be updated status: duplicate A duplicate of another issue; should be closed after linking to the original issue type: enhancement New feature or request

Comments

@tdrews
Copy link
Contributor

tdrews commented Aug 4, 2015

M3U based subtitles (see #133 for some context) use multiple files for a single subtitles track. addExternalCaptions() could be extended to handle these types of subtitles. Work required for this feature may overlap with work required to implement TTML support (#111).

@tdrews tdrews added the type: enhancement New feature or request label Aug 4, 2015
@tdrews tdrews added this to the v1.6.0 milestone Aug 6, 2015
@joeyparrish joeyparrish removed this from the v1.6.0 milestone Aug 14, 2015
@joeyparrish
Copy link
Member

Unfortunately, we don't have the bandwidth right now to add this. It basically amounts to subtitle manifest outside of the main content's manifest, and it doesn't fit into our current architecture.

It is trivial to add vtt subtitles to a DASH manifest, and if you can't modify the manifest, you can always use addExternalCaptions() in the mean time.

@joeyparrish joeyparrish modified the milestone: Future Aug 21, 2015
joeyparrish added a commit that referenced this issue Dec 13, 2015
Support testing is hierarchical.  Player.support returns an object
mapping out the support present in various parts of the system.

This creates a shell for Player and DrmEngine, and introduces support
tests for MediaSourceEngine, ManifestParser, and DrmEngine.

This also adjusts the way support checks are done for text types, to
allow for expansion into MP4-embedded text types and other segmented
subtitle types.

Text changes related to #150 and #146

Change-Id: I707f01ba52cba6262ee89bee2c1f28d24aca4655
@joeyparrish joeyparrish changed the title M3U subtitles support. HLS subtitles Jan 5, 2016
@joeyparrish joeyparrish modified the milestones: v2.0.0, v2+ Jan 5, 2016
@joeyparrish joeyparrish added the status: duplicate A duplicate of another issue; should be closed after linking to the original issue label Oct 4, 2016
@joeyparrish joeyparrish removed this from the v2+ milestone Oct 4, 2016
@joeyparrish
Copy link
Member

Closing as a duplicate of #279, which is more general and covers all HLS support.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated status: duplicate A duplicate of another issue; should be closed after linking to the original issue type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants