-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLS subtitles #146
Comments
Unfortunately, we don't have the bandwidth right now to add this. It basically amounts to subtitle manifest outside of the main content's manifest, and it doesn't fit into our current architecture. It is trivial to add vtt subtitles to a DASH manifest, and if you can't modify the manifest, you can always use addExternalCaptions() in the mean time. |
Support testing is hierarchical. Player.support returns an object mapping out the support present in various parts of the system. This creates a shell for Player and DrmEngine, and introduces support tests for MediaSourceEngine, ManifestParser, and DrmEngine. This also adjusts the way support checks are done for text types, to allow for expansion into MP4-embedded text types and other segmented subtitle types. Text changes related to #150 and #146 Change-Id: I707f01ba52cba6262ee89bee2c1f28d24aca4655
Closing as a duplicate of #279, which is more general and covers all HLS support. |
M3U based subtitles (see #133 for some context) use multiple files for a single subtitles track.
addExternalCaptions()
could be extended to handle these types of subtitles. Work required for this feature may overlap with work required to implement TTML support (#111).The text was updated successfully, but these errors were encountered: