Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network stall detection #1582

Closed
joeyparrish opened this issue Sep 12, 2018 · 2 comments · Fixed by #3227
Closed

Network stall detection #1582

joeyparrish opened this issue Sep 12, 2018 · 2 comments · Fixed by #3227
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v3.1

Comments

@joeyparrish
Copy link
Member

In #1578, there was a network stall that could only be worked around with a timeout. It would be better if we could detect the stall itself, rather than relying on an overall timeout.

In today's system, we can only detect that a request overall takes too long, and abort it. Ideally, we could have a separate timeout for stalls. For example, if timeout is 60s, and stallTimeout is 5s, it would mean that the request overall could take up to 60s, but that if we ever went 5s with no progress at all, the request would be aborted anyway.
@joeyparrish joeyparrish added the type: enhancement New feature or request label Sep 12, 2018
@joeyparrish joeyparrish added this to the Backlog milestone Sep 12, 2018
@joeyparrish joeyparrish mentioned this issue Sep 12, 2018
Closed
@chrisfillmore
Copy link
Contributor

Does this depend on #1504?

@joeyparrish
Copy link
Member Author

Yes, I believe so.

@joeyparrish joeyparrish modified the milestones: Backlog, Backlog 2 Jan 28, 2020
@avelad avelad mentioned this issue Mar 15, 2021
Merged
joeyparrish pushed a commit that referenced this issue Mar 30, 2021
feat: Network stall detection (#3227)
863e345 
Closes: #1582
@joeyparrish joeyparrish modified the milestones: Backlog, v3.1 Apr 12, 2021
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 29, 2021
@shaka-project shaka-project locked and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v3.1
Development

Successfully merging a pull request may close this issue.

Network stall detection avelad/shaka-player
3 participants
@joeyparrish @chrisfillmore @shaka-bot