Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'S' elements with negative 'r' attributes in SegmentTimeline. #162

Closed
tdrews opened this issue Aug 21, 2015 · 2 comments
Closed

Support 'S' elements with negative 'r' attributes in SegmentTimeline. #162

tdrews opened this issue Aug 21, 2015 · 2 comments
Assignees
@TheModMaker
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v1.5.0

Comments

@tdrews
Copy link
Contributor

tdrews commented Aug 21, 2015

A negative 'r' attribute indicates that a specified segment spans until the 't' attribute of the specified segment following it or to the end of the Period.
@tdrews tdrews added type: enhancement New feature or request flag: good first issue This might be a relatively easy issue; good for new contributors labels Aug 21, 2015
@tdrews tdrews added this to the v1.5.0 milestone Aug 21, 2015
@TheModMaker TheModMaker self-assigned this Aug 21, 2015
@priyajeet
Copy link

Thanks for getting this implemented. One thing I did notice was that the MPD fetching bypasses the request callback. Wouldn't requesting the MPD also go through the callback for consistancy?

@tdrews
Copy link
Contributor Author

tdrews commented Aug 24, 2015

I assume that the above comment pertains to #148. Please see my response there.

@tdrews tdrews mentioned this issue Aug 24, 2015
Closed
TheModMaker added a commit that referenced this issue Aug 25, 2015
@TheModMaker
Added partial support to specify negative r values in SegmentTimeline
fdcee73 
Can now specify negative values for the r attribute in SegmentTimeline.
Not supported with live when used on the last element.

Issue #162

Change-Id: I7206e02f7af469a7daf1e4710befb2d102f4f979
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
5 participants
@priyajeet @TheModMaker @joeyparrish @tdrews @shaka-bot