Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with a long term strategy for getting and building localized strings #1688

Closed
ismena opened this issue Nov 19, 2018 · 0 comments
Closed
Assignees
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@ismena
Copy link
Contributor

ismena commented Nov 19, 2018

No description provided.

@ismena ismena added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI labels Nov 19, 2018
@shaka-bot shaka-bot added this to the Backlog milestone Nov 19, 2018
@joeyparrish joeyparrish modified the milestones: Backlog, v2.5 Apr 2, 2019
shaka-bot pushed a commit that referenced this issue Apr 3, 2019
The generate-locales script had to be renamed to camelCase to allow
import as a module in python.  This is pre-work to make the following
commit's diff easier to read.

Issue #1688

Change-Id: I7368573269e201b295d99c080b901f92a3c3d6e1
shaka-bot pushed a commit that referenced this issue Apr 10, 2019
This changes the format of the localization data to enable apps to
trivially lazy-load translations.  It also adds --locales to the build
scripts to allow app developers to choose the compiled-in locales.
The generated output now goes into dist/ and is not checked into
revision control.  Finally, it adds "description" and "meaning" fields
to the source messages to allow us to more easily integrate with a
context-aware human translation service.  The "description" field
provides application context for the translator, while the "meaning"
field provides linguistic disambiguation for words with multiple
meanings or parts of speech in the original English.

Because the translation service wants to collapse messages with
identical text, we had to merge several messages together.  To this
end, we have removed the prefixes "ARIA_LABEL_" and "LABEL_" from the
messages themselves and collapsed what remained.

Issue #1688

Change-Id: I24c17e71c73f6663cf123cfdba118c486fa80ecc
shaka-bot pushed a commit that referenced this issue Apr 10, 2019
The demo app will now respond to events from the localization system
to lazy-load missing localization data at runtime.  This will enable
the demo app to display a localized UI in non-compile-time-default
locales.

This required several changes to the compiled build to add missing
export annotations and quoted strings on event fields.

Issue #1688

Change-Id: I1e756d8ce7861bf822ec0e7d4090f143a201d422
shaka-bot pushed a commit that referenced this issue May 3, 2019
Issue #1688

Change-Id: I5cd7b67a6e4f5d0476c1723e1d9f4b0c825597ea
@shaka-project shaka-project locked and limited conversation to collaborators Jun 10, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants