Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting maxBandwidth to less than lowest bandwidth track plays highest bandwidth track #170

Closed
sanbornhilland opened this issue Aug 27, 2015 · 3 comments
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@sanbornhilland
Copy link
Contributor

If you have a track with multiple video variants, set the maxBandwidth property to less than the bandwidth of the lowest variant. (ex: if the lowest quality is 135000, set maxBandwidth to 100000). The player will then start fetching chunks from the highest quality available. Ideally if your restrictions are set below the level of the lowest variant, the player should start fetching the lowest quality videos chunks, not the highest.

@joeyparrish
Copy link
Member

Good catch. Essentially, the restrictions make it so that there are no usable tracks. This isn't a scenario we had really considered, so we need to decide how we want the Player to behave if this happens.

In the mean time, at an application level, you should definitely not place external limits that result in all tracks being restricted and unusable.

@sanbornhilland
Copy link
Contributor Author

Yeah this is really low priority for us because we have no reason to set restrictions like this. It just seems like counterintuitive behaviour so I figured I'd report it.

@joeyparrish joeyparrish modified the milestone: v1.6.0 Sep 1, 2015
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Sep 8, 2015
@joeyparrish joeyparrish modified the milestones: v1.5.0, v1.6.0 Sep 8, 2015
@tdrews tdrews self-assigned this Sep 11, 2015
@sanbornhilland
Copy link
Contributor Author

Quick update: With the latest change, it seems the behaviour is different now. Instead of playing the highest track it fails with cannot read property 'segmentIndexSource' of null.

@tdrews tdrews modified the milestones: v1.5.0, v1.6.0 Sep 11, 2015
@tdrews tdrews closed this as completed in 5e84b9b Sep 15, 2015
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

5 participants