Audio + Role Shows Roles From Video Stream #1731
Assignees
Labels
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
|
This came from a change I made. I changed |
vaage
added
type: bug
vaage
changed the title
shaka-bot
pushed a commit
that referenced
this issue
Dec 18, 2018
A change to how we collect the audio-lanugage-role pairs allowed the video roles to be included. This change adds a test to make sure that does not happen. It will fail now and be fixed in a later CL. Issue #1731 Change-Id: I1178fce70f38ff7b6d9ddabfb73157985f6f63b6
shaka-bot
pushed a commit
that referenced
this issue
Dec 18, 2018
Rather than using tracks (that merge the roles) use the streams when creating the audio-language-role pairs. The reason we tried using tracks was to remove the need to handle audio muxed into video streams. With this change, that problem is back but we fixed the broken behaviour. Issue #1731 Change-Id: I837406469195956089f33f93f4a9e3c64ffbeab2
|
This should be fixed now. @jakubvojacek could you verify on your end that this has in-fact resolved your issue and report back to us? |
vaage
added
the
status: waiting on response
|
Thank you @vaage, I already tried but it's failing due to mux.js error I mentioned here #1404 (comment). |
|
Okay, I will close this one for now. If it is still an issue after #1404 is resolved, please re-open this issue. |
vaage
removed
the
status: waiting on response
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Have you read the FAQ and checked for duplicate open issues?:
yes
What version of Shaka Player are you using?:
2.5 beta
Can you reproduce the issue with our latest release version?:
no (i mean 2.4.5)
Can you reproduce the issue with the latest code from
master?:yes
Are you using the demo app or your own custom app?:
both
If custom app, can you reproduce the issue using our demo app?:
using nightly build at https://nightly-dot-shaka-player-demo.appspot.com/demo/ yes
What browser and OS are you using?:
mac os & chrome
What are the manifest and license server URIs?:
MPD is available at https://goo.gl/79XrFA and for license URL you can enter anything, to have the playback isnt important.
What did you do?
Loaded the MPD
What did you expect to happen?
to open up the available audio languages and see correct roles
What actually happened?
There should only be one audio language marked with main role (the Russian language). In works well in https://shaka-player-demo.appspot.com/demo/ but in the https://nightly-dot-shaka-player-demo.appspot.com/demo it does not
vs screenshot from stable
The text was updated successfully, but these errors were encountered: