Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'setBytes' of undefined #1930

Closed
pszemus opened this issue May 9, 2019 · 2 comments
Closed

Cannot read property 'setBytes' of undefined #1930

pszemus opened this issue May 9, 2019 · 2 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly

Comments

@pszemus
Copy link
Contributor

pszemus commented May 9, 2019

Have you read the FAQ and checked for duplicate open issues?
yes

What version of Shaka Player are you using?
2.5.0
https://ajax.googleapis.com/ajax/libs/shaka-player/2.5.0/shaka-player.compiled.debug.js

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from master?
don't know

Are you using the demo app or your own custom app?
custom

If custom app, can you reproduce the issue using our demo app?
yes

What browser and OS are you using?
Chrome 74.0.3729.131, Fedora 29

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What did you do?
I configured player like this:

player.configure({
	streaming: {
		retryParameters: {
			timeout: 7000
		}
	}
});

Then I started playing a DASH stream and, after a while, I throttled my network to 1Mbps.

What did you expect to happen?
I expect that after 7000ms downloading will abort, new network bandwidth will be computed and player will start downloading lower bitrate rendition (like described in #1051)

What actually happened?
After 7000ms downloading a chunk JS error occured:

Uncaught (in promise) TypeError: Cannot read property 'setBytes' of undefined
    at networking_engine.js:514
    at $jscomp.generator.Engine_.program_ (http_fetch_plugin.js:154)
    at $jscomp.generator.Engine_.nextStep_ (generator_engine] :795)
    at $jscomp.generator.Engine_.next_ (generator_engine] :699)
    at $jscomp.generator.Generator_.next (generator_engine] :833)
    at b (execute_async_generator] :48)

image

@theodab theodab added type: bug Something isn't working correctly and removed needs triage labels May 9, 2019
@theodab
Copy link
Collaborator

theodab commented May 9, 2019

I was unable to reproduce this bug myself, but I am fairly sure that this CL should fix it. If it does not, feel free to re-open the issue.

@pszemus
Copy link
Contributor Author

pszemus commented May 10, 2019

I can confirm that now it's fixed. Thank you.

joeyparrish pushed a commit that referenced this issue May 20, 2019
The numBytesRemainingObj parameter in |NetworkingEngine.send_| was
optional, but in some circumstances we were assuming that it was set.
This just changes the parameter to be non-optional.
In fact, the parameter now being non-optional revealed an error that
caused the numBytesRemainingObj to be lost on network retry.

Fixes #1930

Change-Id: I74f24309f859f975f51e20455739b806ed3f4ecd
@shaka-project shaka-project locked and limited conversation to collaborators Jul 8, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants