Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaKeys.isTypeSupported is deprecated #2

Closed
joeyparrish opened this issue Dec 29, 2014 · 2 comments
Closed

MediaKeys.isTypeSupported is deprecated #2

joeyparrish opened this issue Dec 29, 2014 · 2 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@joeyparrish
Copy link
Member

We currently rely on MediaKeys.isTypeSupported, which is deprecated and has been removed from recent drafts of the EME spec. This should not be used to check for key system support.

This will only cause problems IF:

  1. you are running Chrome 41 (canary)
  2. AND you have flipped the "Enabled Encrypted Media Extensions" flag
  3. AND you have flipped the "Disable prefixed Encrypted Media Extensions" flag

Users running a typical configuration of Chrome will not see any issues with this.

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Dec 29, 2014
@joeyparrish joeyparrish self-assigned this Dec 29, 2014
@joeyparrish joeyparrish added this to the v1.2 milestone Dec 29, 2014
@ddorwin
Copy link

ddorwin commented Jan 6, 2015

The scenario above generates an exception that completely breaks the player. Thus, the player's unprefixed EME support can't be used at all. Does it make sense to just remove the isTypeSupported() calls and replace them with some reasonable assumptions until a more permanent fix can be implemented?

@joeyparrish
Copy link
Member Author

We could code those assumptions into a polyfill specifically for MediaKeys.isTypeSupported, and reasonably get that into our bugfix release v1.1. This is tentatively scheduled for release on Jan 15.

The real fix is to quit relying on the concept of isTypeSupported, and instead to use the supportedConfigurations parameter of navigator.requestMediaKeySystemAccess. This will require the refactor of several internal classes, which won't be ready until v1.2.

I will file another issue to track the polyfill which will provide a fake isTypeSupported for v1.1.

joeyparrish added a commit that referenced this issue Feb 24, 2015
This is related to the fix for #2.

Change-Id: I2bec5f9d2b44c4801106d2902054a518d1444d2f
forbesjo added a commit to forbesjo/shaka-player that referenced this issue Aug 29, 2017
* Don't mutate the global VTTCue

* Remove doc note

* Update tests

* Use stub function for test
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants