Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume playback after network disconnection #28

Closed
sanbornhilland opened this issue Mar 9, 2015 · 1 comment
Closed

Resume playback after network disconnection #28

sanbornhilland opened this issue Mar 9, 2015 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@sanbornhilland
Copy link
Contributor

I've noticed that if you lose your network connection during playback and then it reconnects, the player won't continue to buffer new data. However, the video element will still send 'playing' events if you press play. Is there any intention to add support for recovering form a network failure? And if not, is there any recommendation for determining when playback is actually happening because clearly the 'playing' event is not a reliable indicator of playback.

Thanks for the hard work guys. Cheers.

@joeyparrish
Copy link
Member

Good point. Although whether or not to retry after a network failure could be considered an application-level decision, the application currently has no choice.

If we make shaka.media.Stream not only dispatch an error, but also set a timer to retry, then the application would have the choice of whether or not to shut down the Player when it sees the error event.

@joeyparrish joeyparrish self-assigned this Mar 9, 2015
@joeyparrish joeyparrish added this to the v1.3.0 milestone Mar 9, 2015
@joeyparrish joeyparrish added the type: enhancement New feature or request label Mar 9, 2015
joeyparrish added a commit that referenced this issue Mar 10, 2015
Closes #28.

Change-Id: I09df3e2fbb631ca1215e5d44baa9ada67ede9cee
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants