Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double tap to forward/seek in the video #3357

Closed
FireMasterK opened this issue Apr 21, 2021 · 5 comments · Fixed by #5943
Closed

Double tap to forward/seek in the video #3357

FireMasterK opened this issue Apr 21, 2021 · 5 comments · Fixed by #5943
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@FireMasterK
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

Is your feature request related to a problem? Please describe.

On Android on chromium, the native player supports seeking using double taps on the edge of the screen.

Describe the solution you'd like
An implementation is shaka-player UI.

Describe alternatives you've considered
An own implementation, but I'm unsure where to start. I feel this should be included in shaka-player considering the native player already supports it.

Additional context
I've tested on the demo page as well.

@michellezhuogg michellezhuogg added flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this type: enhancement New feature or request component: UI The issue involves the Shaka Player UI and removed needs triage labels Apr 21, 2021
@anshgo01yal
Copy link
Contributor

hello, I have an approach to solve this problem what we can do is create an element both sides of the player and add DoubleClick event to forward/seek video even we can create a loop for ex if double click skip 10 sec ,triple click 20 sec and so on.
please let me know if I am right.

@shaka-bot shaka-bot added this to the Backlog milestone Apr 21, 2021
@FireMasterK
Copy link
Author

That's one way to solve it! However, I'm a bit unsure whether the approach would work without buttons.

@joeyparrish
Copy link
Member

You could listen for the double-click events on parts of the video frame by positioning transparent elements there.

I've seen UIs where on double-tap on the right, a "fast-forward" icon appears with some text showing how far it is skipping. That could be an element which is always present, receives the double-click/tap events, and shows itself briefly when activated before becoming transparent again.

@surajkumar-sk
Copy link
Contributor

surajkumar-sk commented Apr 21, 2021

For anyone who wants to work on this .

  1. We could create two functions in ui/controls.js file , one addfastforwardbuttondiv() the other addrewindbutton() . I am terrible at name so think of something .
  2. Inside it create a div , then create a span tag add text 10s or any time.
  3. Create three classes in ui/less/button.less one for rewind and other for forward button . Add some font size, alignment and other things to make it fit . The third one to hide them .
  4. Add an event listener to both the buttons to listen to dblclick for double mouse click . And for double tap on phone , there are few lines you might need .This link has the answer for it . Use these events to add classes to div . There is a function called seek_() which you could add to run when that event is triggered for making the video go backward or forward by any amount.
  5. You should also create a timer variable to hide the the divs . Which will probably tick 0.5 or 1s after the event is launched . Use this timmer function to add and remove classes from div and hide it.
  6. Finally append this to videocontainer_

I think this will add this functionality but it will also interfere with full-screen on double click feature . Thus will almost make the full screen feature useless.

@surajkumar-sk
Copy link
Contributor

surajkumar-sk commented Apr 27, 2021

Noone seems to be doing this, so I'll add a pr.

@TheModMaker TheModMaker added the priority: P2 Smaller impact or easy workaround label Sep 29, 2021
@avelad avelad removed the flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this label Nov 28, 2023
@avelad avelad modified the milestones: Backlog, v5.0 Nov 28, 2023
avelad added a commit that referenced this issue Nov 29, 2023
Closes #3357
Closes #3303

Thanks to @surajkumar-sk, his
#3373 has been the
inspiration for this.
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 28, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
8 participants