-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TTML displayAlign broken in 3.1 #3379
Comments
Note: it is a regression of 3.1 in 3.0.x it works fine. |
@ismena , Since issues are now labeled with priorities, is there an estimated time for issues with different priorities to be resolved? After analyzing the release 3.1 this is the only problem to be able to migrate to it :( |
P0 (top priority) will generally mean that someone needs to drop everything else until it's done. These are bugs that break something major for everyone. |
Bug introduced with 9c2315e |
@joeyparrish is there any way to prioritize this? For me this is blocking the integration of release 3.1. I've tried to fix the problem and do a PR, but I don't see any way to fix it without using FLEX, which is just what you removed in 9c2315e. |
I'll work on it now. |
Repro:
video.muted = true;
player = video.ui.getControls().getLocalPlayer();
await player.addTextTrackAsync('../3379.ttml', 'es', 'subtitle', 'application/ttml+xml');
player.selectTextLanguage('es');
player.setTextTrackVisibility(true); The div is placed correctly and has the correct size, but |
You're right, it's easily-solved with flexbox layout. I haven't come up with an alternative yet. I will see what breaks in our layout tests with flexbox and work backward. Perhaps I can make the existing tests pass and avoid recreating bug #3013. |
Issues discovered while playing with
Side-note: the |
@joeyparrish , have you found any solutions for the problems you have encountered? |
Potentially. See my earlier workaround comment, which I'm trying to turn into a concrete solution:
|
I'm resuming work on this today. Sorry for the delays. |
I have it working now, plus regression tests, and the change is in review. Thanks for your patience! |
This uses flexbox once again to get proper positioning of cues. To compensate for the issues that originally made us remove flexbox, this adds a wrapper span inside the flexbox element. Summary of screenshot changes: - slight change to background sizing - ui-basic-cue - ui-cue-with-controls - ui-duplicate-cues - ui-end-time-edge-case - ui-flat-cue-bg - ui-two-basic-cues - background fills block with literal newline in text - ui-cue-with-newline - region anchored without padding - ui-region-position - new screenshots - *-nested-cues-with-linebreak - *-region-with-display-alignment (regression test for this issue) Closes #3379 Change-Id: I8c678721d96662e0f8940cda12df4f5b5e5baf1e
Have you read the FAQ and checked for duplicate open issues? Yes
What version of Shaka Player are you using? 3.1.0
Can you reproduce the issue with our latest release version? Yes
Can you reproduce the issue with the latest code from
master
? YesAre you using the demo app or your own custom app? Both
If custom app, can you reproduce the issue using our demo app? Yes
What browser and OS are you using?
Chrome 90 macOS 10.15.7
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
Subtitle example:
subtitle.ttml.zip
What configuration are you using? What is the output of
player.getConfiguration()
?N/A
What did you do?
Load any stream with the previous TTML
What did you expect to happen?
The subtitle is rendered correctly
What actually happened?
tts:displayAlign="after"
is ignored (verticalAlign style in UITextDisplayer doesn't have effect)http://sandflow.com/imsc1_1/
![image](https://user-images.githubusercontent.com/8983024/116662108-a6e24500-a995-11eb-9703-00a80c4b05b6.png)
The text was updated successfully, but these errors were encountered: