Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABR not respect user preferrence resolution #3385

Closed
kocoten1992 opened this issue May 4, 2021 · 1 comment · Fixed by #3387
Closed

ABR not respect user preferrence resolution #3385

kocoten1992 opened this issue May 4, 2021 · 1 comment · Fixed by #3387
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@kocoten1992
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
v3.1.0

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Not sure, I'm using demo app to reproduce this

Are you using the demo app or your own custom app?
demo app

What browser and OS are you using?
Google Chrome

What did you do?

  1. Go to https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://storage.googleapis.com/shaka-demo-assets/sintel-widevine/dash.mpd;adTagUri=https://pubads.g.doubleclick.net/gampad/ads?sz=640x480&iu=/124319096/external/ad_rule_samples&ciu_szs=300x250&ad_rule=1&impl=s&gdfp_req=1&env=vp&output=vmap&unviewed_position_start=1&cust_params=deployment%3Ddevsite%26sample_ar%3Dpremidpostpod&cmsid=496&vid=short_onecue&correlator=;panel=HOME;build=uncompiled
  2. select highest resolution, watch for about 10s
  3. open network tab and throttle bandwidth to slow 3G

What did you expect to happen?
Video keep playing at user chosen resolution regardless of lagging.

What actually happened?
ABR kick in and downgrade resolution (resolution on menu still display the same - but you can see clearly the real video quality is much downgrade).
ABR should not override user preferrence and select different resolution for user, previous version don't do this - maybe this is a regression ?.

@joeyparrish
Copy link
Member

Sounds like a regression, and it looks to me like it was introduced in #2663 . There should be a check there for the enabled state of the ABR manager before reacting to the network change event.

@joeyparrish joeyparrish added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release and removed needs triage labels May 4, 2021
@shaka-bot shaka-bot added this to the v3.2 milestone May 4, 2021
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 4, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants