Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPEG-2 TS not working with 3.1 and mux.js #3407

Closed
Benny739 opened this issue May 13, 2021 · 4 comments
Closed

MPEG-2 TS not working with 3.1 and mux.js #3407

Benny739 opened this issue May 13, 2021 · 4 comments
Assignees
@joeyparrish
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.2

Comments

@Benny739
Copy link

MPEG-2 TS transmuxing via mux.js is not working in 3.1. 3.0.7 is working fine.
@joeyparrish
Copy link
Member

Working fine for me: https://shaka-player-demo.appspot.com/demo/#audiolang=de;textlang=de;uilang=de;asset=https://bitdash-a.akamaihd.net/content/MI201109210084_1/m3u8s/f08e80da-bf1d-4e3d-8899-f0f6155f6efa.m3u8;panel=ALL_CONTENT;panelData=MP2TS;build=uncompiled

Do you have repro steps for us to follow? Specific content? Can you reproduce the issue in our demo? All of these questions were in the issue template that you deleted. Next time, please use the template so that we have all the necessary information to investigate your issue.

@joeyparrish joeyparrish added status: unable to reproduce Issue could not be reproduced by the team status: waiting on response Waiting on a response from the reporter(s) of the issue labels May 13, 2021
@Benny739
Copy link
Author

Sorry for the short bug report, I created 2 codepens:
The codepens are completely identical, one is with 3.0.6 the other with 3.1.

3.0.6 working:
https://codepen.io/benny739/pen/GRomJWE

3.1 not working:
https://codepen.io/benny739/pen/wvJGmJY

It looks like in 3.1 it's throwing error 4032, CONTENT_UNSUPPORTED_BY_BROWSER.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label May 14, 2021
@joeyparrish
Copy link
Member

Your codepen fails with the same content that works fine in our demo. Something is different in the codepen, and I'm not sure what.

I tried using both compiled & uncompiled code in our demo, and both work. So the compiler didn't break anything.

Still investigating.

@joeyparrish
Copy link
Member

I found the issue. You need to load mux.min.js before Shaka Player.

This shouldn't be required, though. So long as muxjs is loaded by the time you call player.load(), we would expect everything to work.

The change in behavior occured with the introduction of shaka.dependencies in PR #2683. It was meant to allow apps to inject their own muxjs without loading it globally, but it accidentally created an ordering requirement.

I will see if I can find a simple way to fix it. In the meantime, please change the order of scripts so that mux.js is loaded before Shaka Player. This seems to be an effective workaround.

@joeyparrish joeyparrish added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround and removed status: unable to reproduce Issue could not be reproduced by the team labels May 14, 2021
@joeyparrish joeyparrish self-assigned this May 14, 2021
@shaka-bot shaka-bot added this to the v3.2 milestone May 14, 2021
ismena pushed a commit that referenced this issue May 17, 2021
@joeyparrish @ismena
fix: Allow muxjs to be loaded after Shaka
02a0fbf 
In PR #2683, a dependency-injection system was added to Shaka Player.
However, it would capture default deps from a global scope at
load-time.  This introduced an accidental ordering requirement where
muxjs would have to be loaded first.  This was not required in v3.0.x,
so it should not have become a requirement in v3.1.

To fix this issue, dependencies are now stored as lazy callbacks.  So
long as muxjs is loaded before Shaka Player tries to play TS content,
it no longer matters when they each were loaded into the page.  This
restores the v3.0.x behavior without breaking the dependency-injection
system or its API.

Closes #3407

Change-Id: Ia6e0a68bea88f0cdb614e8751edc70147bc67f28
@renovate renovate bot mentioned this issue Jun 17, 2021
Merged
1 task
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 13, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.2
Development

No branches or pull requests
3 participants
@joeyparrish @shaka-bot @Benny739