Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'numEvicted' of null #3423

Closed
Dawolee opened this issue May 24, 2021 · 3 comments
Closed

Cannot read property 'numEvicted' of null #3423

Dawolee opened this issue May 24, 2021 · 3 comments
Assignees
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@Dawolee
Copy link

Dawolee commented May 24, 2021

Have you read the FAQ and checked for duplicate open issues?
Yes, this is the duplicate issue: #3323 but I was told by an engineer on our end (JW Player) that Joey had said to file a new issue as we were able to reproduce the behavior consistently.

What version of Shaka Player are you using?
3.1.0 (Currently live demo page)

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
N/A

Are you using the demo app or your own custom app?
Demo app

If custom app, can you reproduce the issue using our demo app?
N/A

What browser and OS are you using?
Chrome 90.0.4430.212 in MacOS 10.15.7

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

demo app URI: https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://cdn-er-test2.online.meo.pt/prd-pcs1/sdash/LIVE$RTP1_HD/index.mpd/Manifest?device=ATV_Live&start=LIVE&end=END;panel=CUSTOM%20CONTENT;build=uncompiled

What configuration are you using? What is the output of player.getConfiguration()?

What did you do?

  1. Navigate to demo app page
  2. Click Custom Content and for manifest URL, enter:
    https://cdn-er-test2.online.meo.pt/prd-pcs1/sdash/LIVE$RTP1_HD/index.mpd/Manifest?device=ATV_Live&start=LIVE&end=END (a stream we received from a customer on our end)
  3. Click play and the error message should show up.

What did you expect to happen?
The stream should play

What actually happened?

The stream does not play and Cannot read property 'numEvicted' of null shows up:

@theodab
Copy link
Collaborator

theodab commented May 25, 2021

Yeah, this definitely seems like a bug. I think we aren't handling that SegmentTimeline in the trick mode AdaptationSet correctly. We are doing something wrong when we combine the streams.
I'll look into the exact bug that's causing this.

@theodab theodab added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release and removed needs triage labels May 25, 2021
@theodab theodab self-assigned this May 25, 2021
@shaka-bot shaka-bot added this to the v3.2 milestone May 25, 2021
@Dawolee
Copy link
Author

Dawolee commented May 25, 2021

Thank you for confirming!

@theodab
Copy link
Collaborator

theodab commented May 25, 2021

That CL should fix the problem. If you're still seeing issues, feel free to bring them up with us.

joeyparrish pushed a commit that referenced this issue Jun 16, 2021
When concatenating trick mode streams, at the moment, the period
combiner assumes that the streams already have segment indexes.
However, we never actually make those segment indexes in the period
combiner, causing it to break in that situation.
This modifies the period combiner to also create the segment index
of a video stream's trick mode stream when creating the main segment
index of the stream.

Fixes #3423

Change-Id: I4ca6f14879b7a5d3dae735e931d2fb1f8d1673be
joeyparrish pushed a commit that referenced this issue Jun 16, 2021
When concatenating trick mode streams, at the moment, the period
combiner assumes that the streams already have segment indexes.
However, we never actually make those segment indexes in the period
combiner, causing it to break in that situation.
This modifies the period combiner to also create the segment index
of a video stream's trick mode stream when creating the main segment
index of the stream.

Fixes #3423

Change-Id: I4ca6f14879b7a5d3dae735e931d2fb1f8d1673be
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 24, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants