Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay button does not have correct aria-label #3512

Closed
agliga opened this issue Jul 7, 2021 · 0 comments · Fixed by #3513
Closed

Replay button does not have correct aria-label #3512

agliga opened this issue Jul 7, 2021 · 0 comments · Fixed by #3513
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: accessibility An accessibility issue type: bug Something isn't working correctly
Milestone
v3.2

Comments

@agliga
Copy link

agliga commented Jul 7, 2021

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.1.1

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Yes

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Any

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

N/A

What configuration are you using? What is the output of player.getConfiguration()?

N/A

What did you do?

When the video ends, I expect the replay button to have aria-label of replay not play, to denote to users that the video has ended and clicking this button will replay the video from the start
https://github.com/google/shaka-player/blob/4c975621a0110a7e6d21be2b8e2cebeb80e1cb1c/ui/small_play_button.js#L37-L45 This needs to also have aria-label changes, or to update the updateAriaLabel method.

What did you expect to happen?
The aria-label should be replay

What actually happened?

The aria-label stays as play
Screen Shot 2021-07-07 at 11 57 21 AM
@joeyparrish joeyparrish added type: bug Something isn't working correctly type: accessibility An accessibility issue component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround and removed needs triage labels Jul 7, 2021
@shaka-bot shaka-bot added this to the v3.2 milestone Jul 7, 2021
@avelad avelad mentioned this issue Jul 8, 2021
Merged
joeyparrish pushed a commit that referenced this issue Jul 8, 2021
Fix: Fix ARIA label on replay button (#3513)
2dedd9f 
Close: #3512
@agliga agliga mentioned this issue Jul 9, 2021
Closed
joeyparrish pushed a commit that referenced this issue Jul 13, 2021
@joeyparrish
Fix: Fix ARIA label on replay button (#3513)
efc6560 
Close: #3512
joeyparrish pushed a commit that referenced this issue Jul 13, 2021
@joeyparrish
Fix: Fix ARIA label on replay button (#3513)
2f9ccc3 
Close: #3512

Backported to v3.0.x

Change-Id: I20df8c4b9cf621dad75f4d981bd04571fcaf481e
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 6, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: accessibility An accessibility issue type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.2
Development

Successfully merging a pull request may close this issue.

Fix: Replay button does not have correct aria-label avelad/shaka-player
3 participants
@agliga @joeyparrish @shaka-bot