Subtitle cues nested within a parent cue with infinite time range always displayed regardless of child time ranges #3524
Assignees
Labels
component: captions/subtitles
The issue involves captions or subtitles
priority: P1
Big impact or workaround impractical; resolve before feature release
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
11 tasks
joeyparrish
added
type: bug
theodab
added
the
component: captions/subtitles
|
It looks like we fixed this by accident in 157bd77. Sorry for not seeing your PR earlier! |
shaka-bot
pushed a commit
that referenced
this issue
Oct 6, 2021
Previously, we added support for respecting the time constraints of nested cues. However, the UI text displayer did not take the time constraints of nested cues into account when determining when and how to update the cues. This changes the UI text displayer to also do that. Issue #3524 Issue #3643 Change-Id: I6b643f2aa21f367a8e40a8aca2ebb62492c071c2
joeyparrish
pushed a commit
that referenced
this issue
Oct 12, 2021
Previously, we added support for respecting the time constraints of nested cues. However, the UI text displayer did not take the time constraints of nested cues into account when determining when and how to update the cues. This changes the UI text displayer to also do that. Issue #3524 Issue #3643 Change-Id: I6b643f2aa21f367a8e40a8aca2ebb62492c071c2
joeyparrish
pushed a commit
that referenced
this issue
Oct 12, 2021
Previously, we added support for respecting the time constraints of nested cues. However, the UI text displayer did not take the time constraints of nested cues into account when determining when and how to update the cues. This changes the UI text displayer to also do that. Issue #3524 Issue #3643 Change-Id: I6b643f2aa21f367a8e40a8aca2ebb62492c071c2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v3.1.1
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
master?Yes
Are you using the demo app or your own custom app?
Both
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
Windows 10
Mac Big Sur
Chrome v91
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?
[clear] http://rdmedia.bbc.co.uk/dash/ondemand/elephants_dream/1/client_manifest-snake.mpd
What configuration are you using? What is the output of
player.getConfiguration()?Default configuration
What did you do?
What did you expect to happen?
Sentence words appear at intervals according to time cues, when the sentence is complete, it clears and the next sentence appears word by word at the intervals indicated in the stream.
What actually happened?
All subtitles dumped on the screen and stay there throughout.
Please assign to me as I have a failing UT and a proposed fix.
The text was updated successfully, but these errors were encountered: