Destroying UI doesn't remove PIP #3553
Assignees
Labels
component: UI
The issue involves the Shaka Player UI
flag: good first issue
This might be a relatively easy issue; good for new contributors
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: enhancement
New feature or request
Milestone
Comments
|
Seems like a reasonable idea to me. |
theodab
added
flag: good first issue
joeyparrish
pushed a commit
that referenced
this issue
Oct 12, 2021
The UI can open up Picture-in-Picture mode, through the PiP button, but it does not automatically leave PiP mode when being destroyed. This CL adds leaving PiP mode to the destroy process. Closes #3553 Change-Id: I6830a7ceed7e4ca4fbd0e7d36b8257d564e0226c
joeyparrish
pushed a commit
that referenced
this issue
Oct 12, 2021
The UI can open up Picture-in-Picture mode, through the PiP button, but it does not automatically leave PiP mode when being destroyed. This CL adds leaving PiP mode to the destroy process. Closes #3553 Change-Id: I6830a7ceed7e4ca4fbd0e7d36b8257d564e0226c
joeyparrish
pushed a commit
that referenced
this issue
Oct 12, 2021
The UI can open up Picture-in-Picture mode, through the PiP button, but it does not automatically leave PiP mode when being destroyed. This CL adds leaving PiP mode to the destroy process. Closes #3553 Change-Id: I6830a7ceed7e4ca4fbd0e7d36b8257d564e0226c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
3.2.0
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
master?Haven't tried
Are you using the demo app or your own custom app?
Custom App
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
Chromium and Brave, Linux
What configuration are you using? What is the output of
player.getConfiguration()?Shouldn't matter
What did you do?
document.querySelector("video").ui.destroy()in the javascript consoleWhat did you expect to happen?
The Picture-In-Picture popup to disappear as well.
What actually happened?
The picture-in-picture popup stayed, with it being stuck on the last played frame.
The text was updated successfully, but these errors were encountered: