Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing metadata event with timed ID3 data in HLS stream from Telos Z/IPStream X/2 encoder #3761

Closed
pszemus opened this issue Nov 18, 2021 · 5 comments · Fixed by #4259 or #4235
Closed
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly type: external An issue with an external dependency; not our issue; sometimes kept open for tracking
Milestone

Comments

@pszemus
Copy link
Contributor

pszemus commented Nov 18, 2021

Have you read the FAQ and checked for duplicate open issues?
yes

What version of Shaka Player are you using?
v3.2.1 (uncompiled)

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from master?
didn't try

Are you using the demo app or your own custom app?
demo app

What browser and OS are you using?
Google Chrome 96.0.4664.45

What are the manifest and license server URIs?
https://wptv-devel.wpcdn.pl/open.fm/S04-HLS1-httpLS.m3u8

What configuration are you using? What is the output of player.getConfiguration()?
default demo app configuration

What did you do?
In demo app:

  1. start playing https://wptv-devel.wpcdn.pl/open.fm/S04-HLS1-httpLS.m3u8
  2. add metadata event listener: shakaDemoMain.player_.addEventListener('metadata', (e) => {console.log("[t: " + shakaDemoMain.player_.getMediaElement().currentTime + "] MetadataEvent event", e);});

What did you expect to happen?

After about 1 minute of playing there should be 2 metadata events.
Hls.js shows them correctly:
image

What actually happened?
No metadata event fired.

@pszemus pszemus added the type: bug Something isn't working correctly label Nov 18, 2021
@shaka-bot shaka-bot added this to the v3.3 milestone Nov 18, 2021
@TheModMaker
Copy link
Contributor

I don't think we support the metadata event ourselves. We technically do on Safari since the browser does it for us; but when playing ourselves, I don't think we handle the metadata events/data. We'll keep this as an enhancement to add this.

@TheModMaker TheModMaker added priority: P2 Smaller impact or easy workaround type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format and removed type: bug Something isn't working correctly labels Dec 6, 2021
@pszemus
Copy link
Contributor Author

pszemus commented Dec 7, 2021

@TheModMaker I can send you a sample HLS stream (from Wowza Streaming Engine) where metadata event is published in Chrome.

@avelad
Copy link
Collaborator

avelad commented Dec 17, 2021

Your stream uses TS, and it seems like mux.js says it has metadata with dispatchType = 15, but it doesn't return no data or frames. I suggest you look at the logic of mux.js to see what is happening (https://github.com/videojs/mux.js/blob/main/lib/m2ts/metadata-stream.js).

@avelad
Copy link
Collaborator

avelad commented Feb 21, 2022

mux.js PR --> videojs/mux.js#408

@avelad avelad modified the milestones: v3.3, v4.1 May 4, 2022
@joeyparrish joeyparrish modified the milestones: v4.1, Backlog May 9, 2022
@avelad avelad added type: bug Something isn't working correctly type: external An issue with an external dependency; not our issue; sometimes kept open for tracking and removed type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround labels May 24, 2022
@avelad avelad removed this from the Backlog milestone May 24, 2022
@github-actions github-actions bot added this to the v4.1 milestone May 24, 2022
@joeyparrish
Copy link
Member

I pinged the mux.js PR today to see if we can get the fix merged there.

joeyparrish pushed a commit that referenced this issue May 31, 2022
joeyparrish pushed a commit that referenced this issue Jun 2, 2022
joeyparrish pushed a commit that referenced this issue Jun 2, 2022
joeyparrish pushed a commit that referenced this issue Jun 2, 2022
theodab pushed a commit to theodab/shaka-player that referenced this issue Jun 3, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly type: external An issue with an external dependency; not our issue; sometimes kept open for tracking
Projects
None yet
5 participants