Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced subtitle DASH support checking for wrong Role@value #3767

Closed
theRealRobG opened this issue Nov 23, 2021 · 0 comments · Fixed by #3807
Closed

Forced subtitle DASH support checking for wrong Role@value #3767

theRealRobG opened this issue Nov 23, 2021 · 0 comments · Fixed by #3807
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@theRealRobG
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.2.1

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
N/A

If custom app, can you reproduce the issue using our demo app?
N/A

What browser and OS are you using?
N/A

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

N/A

What configuration are you using? What is the output of player.getConfiguration()?

N/A

What did you do?

The 4th edition of ISO/IEC 23009-1 (publicly available here) has this change:

the ability to signal forced subtitles, easyreader and karaoke in the DASH Role scheme was added;

Shaka added support for forced narrative signalling from DASH in #2938.

What did you expect to happen?
The signalling of forced narrative track would be detected via roles.includes('forced-subtitle');.

This is defined in Table 31 — Role@value attribute for scheme with a value "urn:mpeg:dash:role:2011"

Role@value Description Applicable Media Type(s) (Informative)
forced-subtitle Textual information meant for display when no other text representation is selected. It is used to clarify dialogue, alternate languages, texted graphics or location/person IDs that are not otherwise covered in the dubbed/localized audio. text

What actually happened?

The signalling of forced narrative track is detected via roles.includes('forced_subtitle');.

Table 31 — Role@value attribute for scheme with a value "urn:mpeg:dash:role:2011"

@theRealRobG theRealRobG added the type: bug Something isn't working correctly label Nov 23, 2021
@shaka-bot shaka-bot added this to the v3.3 milestone Nov 23, 2021
theodab pushed a commit that referenced this issue Jan 7, 2022
Previously, Shaka Player only supported "forced_subtitle",
which was the working name before the role was finalized.

Closes #3767
joeyparrish pushed a commit that referenced this issue Jan 7, 2022
Previously, Shaka Player only supported "forced_subtitle",
which was the working name before the role was finalized.

Closes #3767
joeyparrish pushed a commit that referenced this issue Jan 7, 2022
Previously, Shaka Player only supported "forced_subtitle",
which was the working name before the role was finalized.

Closes #3767
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Mar 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants