Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build without text no longer work #3863

Closed
kocoten1992 opened this issue Jan 15, 2022 · 2 comments · Fixed by #4506
Closed

build without text no longer work #3863

kocoten1992 opened this issue Jan 15, 2022 · 2 comments · Fixed by #4506
Assignees
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@kocoten1992
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
yes

What version of Shaka Player are you using?
v3.3.0

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from master?
yes

What did you do?

git clone https://github.com/google/shaka-player
cd shaka-player
python build/build.py +@complete -@polyfill -@text

What did you expect to happen?
it should work

What actually happened?

[INFO] Compiling the library (ui, release)...
/tmp/shaka-player/lib/player.js:37:0: ERROR - [JSC_MISSING_MODULE_OR_PROVIDE] Required namespace "shaka.text.WebVttGenerator" never defined.
  37| goog.require('shaka.text.WebVttGenerator');
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 error(s), 0 warning(s)
[ERROR] Build failed
@kocoten1992 kocoten1992 added the type: bug Something isn't working correctly label Jan 15, 2022
@shaka-bot shaka-bot added this to the v3.3 milestone Jan 15, 2022
@TheModMaker TheModMaker added the priority: P2 Smaller impact or easy workaround label Jan 18, 2022
@MadMods96
Copy link

Respected sir/Madam,

I am Madhusudan Pareek , a computer science undergraduate , I have just entered to my 4th semester at TC College affiliated with Savitri Bai Phule Pune University. I am new to open source but I am well aware of JavaScript , Nodejs, PostgreSQL, MySQL, HTML,CSS, bootstrap, React and also good knowledge of making rest api’s. I would love to contribute to your organization. Currently I had worked with an organization ‘IBKAAS’ as an intern and developed their backend with NodeJS ( express )and PostgreSQL and now I’m looking for open source..

Hoping to hear from you soon.

Regards

Madhusudan

@naktinis
Copy link

To add some context, the error in its current form appeared in 0845843.

Before that, there was already dependency on @text, which was for the first time introduced in faa1e52.

@avelad avelad modified the milestones: v3.3, v4.1 May 4, 2022
@avelad avelad modified the milestones: v4.1, v4.2 Jun 3, 2022
@avelad avelad modified the milestones: v4.2, v4.3 Aug 17, 2022
@avelad avelad self-assigned this Sep 22, 2022
avelad added a commit that referenced this issue Sep 22, 2022
JulianDomingo pushed a commit that referenced this issue Oct 6, 2022
JulianDomingo pushed a commit that referenced this issue Oct 6, 2022
JulianDomingo pushed a commit that referenced this issue Oct 7, 2022
JulianDomingo pushed a commit that referenced this issue Oct 7, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Nov 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants