Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player robustness against network failures #390

Closed
BucherTomas opened this issue May 23, 2016 · 2 comments
Closed

Player robustness against network failures #390

BucherTomas opened this issue May 23, 2016 · 2 comments
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@BucherTomas
Copy link
Contributor

Shaka Player v2.0.0-beta2 is missing some countermeasures for situations, where the network is temporarily disconnected, this typically applies to mobile devices when they are, say, disconnected from the carrier, e.g. going through a tunnel in a car with a passenger watching a video, etc.

Steps to reproduce:

  1. Start playing any video with Chrome developer tools open.
  2. Select offline preset from the list of connectivity simulations in Network tab
  3. Shaka throws HTTP Network error (ID 1002) from which it cannot recuperate, even though the network becomes again available a short while later by switching to No throttling preset.

No amount of standard user interaction (pressing play, or seeking) helps. The media needs to be loaded again.

Shaka v1.6.5 handles this situation by querying last segment indefinitely until the network is available again and then it continues normally. It would be great if Shaka v2 did something similar and even if the error occurs under other circumstances, let it not be so destructive to the playback session.

@tdrews
Copy link
Contributor

tdrews commented May 23, 2016

Yes, we should do this.

@tdrews tdrews added the type: enhancement New feature or request label May 23, 2016
@tdrews tdrews added this to the v2.0.0 milestone May 23, 2016
@tdrews tdrews self-assigned this May 23, 2016
@joeyparrish joeyparrish reopened this Jun 9, 2016
@joeyparrish
Copy link
Member

I think we need two more changes related to this:

  1. change the default retry parameters so that more than one attempt is made by default
  2. since network errors may not be fatal, we should add a small 'dismiss' button to the error div in the demo app to allow a user of the demo to clear the error message

shaka-bot pushed a commit that referenced this issue Jun 13, 2016
Issue #390

Change-Id: I21dd250c5369e8a442eaa3cd13f22a26c418a6d7
shaka-bot pushed a commit that referenced this issue Jun 23, 2016
Issue #390

Change-Id: I1458892f4317176f5aaac9665b6bedfd672a9a12
@tdrews tdrews closed this as completed Jun 27, 2016
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants