Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari tests succeed, then the job times out after 6h #3967

Closed
joeyparrish opened this issue Feb 17, 2022 · 3 comments · Fixed by #4144
Closed

Safari tests succeed, then the job times out after 6h #3967

joeyparrish opened this issue Feb 17, 2022 · 3 comments · Fixed by #4144
Assignees
@joeyparrish
Labels
browser: Safari Issues affecting Safari or WebKit derivatives platform: macOS Issues affecting macOS status: archived Archived and locked; will not be updated type: CI An issue with our continuous integration tests
Milestone
v4.0

Comments

@joeyparrish
Copy link
Member

The Safari tests in GitHub Actions seem to succeed, but the job doesn't shut down properly and eventually times out after ~6h. This could be a bug in karma-local-wd-launcher, which is now responsible for launching and shutting down Safari.
@joeyparrish joeyparrish added type: CI An issue with our continuous integration tests platform: macOS Issues affecting macOS browser: Safari Issues affecting Safari or WebKit derivatives labels Feb 17, 2022
@joeyparrish joeyparrish self-assigned this Feb 17, 2022
@joeyparrish
Copy link
Member Author

See also https://github.com/joeyparrish/karma-local-wd-launcher/issues/24

@joeyparrish joeyparrish mentioned this issue Feb 17, 2022
Closed
@github-actions github-actions bot added this to the Backlog milestone Feb 17, 2022
@joeyparrish
Copy link
Member Author

Logs from such a test run:

5_Test Player.txt

@joeyparrish
Copy link
Member Author

PR in review for karma-local-wd-launcher: shaka-project/karma-local-wd-launcher#38

@joeyparrish joeyparrish mentioned this issue Apr 21, 2022
Merged
joeyparrish added a commit that referenced this issue Apr 21, 2022
@joeyparrish
test: Fix Safari tests hanging in GitHub Actions environment (#4144)
d1699de 
Fixed upstream in shaka-project/karma-local-wd-launcher#38

Closes #3967
joeyparrish added a commit that referenced this issue Apr 21, 2022
@joeyparrish
test: Fix Safari tests hanging in GitHub Actions environment (#4144)
1c2f6ab 
Fixed upstream in shaka-project/karma-local-wd-launcher#38

Closes #3967
joeyparrish added a commit that referenced this issue Apr 21, 2022
@joeyparrish
test: Fix Safari tests hanging in GitHub Actions environment (#4144)
f8e53ba 
Fixed upstream in shaka-project/karma-local-wd-launcher#38

Closes #3967
joeyparrish added a commit that referenced this issue Apr 21, 2022
@joeyparrish
test: Fix Safari tests hanging in GitHub Actions environment (#4144)
c7845d3 
Fixed upstream in shaka-project/karma-local-wd-launcher#38

Closes #3967
@avelad avelad modified the milestones: Backlog, v4.0 May 4, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jun 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
browser: Safari Issues affecting Safari or WebKit derivatives platform: macOS Issues affecting macOS status: archived Archived and locked; will not be updated type: CI An issue with our continuous integration tests
Projects
None yet
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

test: Fix Safari tests hanging in GitHub Actions environment joeyparrish/shaka-player
2 participants
@joeyparrish @avelad