Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captions stops renering after it hits the EMPTY Segmented VTT captions file #4429

Closed
sundip111 opened this issue Aug 19, 2022 · 5 comments
Closed
Labels
component: captions/subtitles The issue involves captions or subtitles component: WebVTT The issue involves WebVTT subtitles specifically status: archived Archived and locked; will not be updated status: bad content Caused by invalid, broken, or unsupported content type: bug Something isn't working correctly
Milestone

Comments

@sundip111
Copy link

Have you read the FAQ and checked for duplicate open issues?

What version of Shaka Player are you using?

Can you reproduce the issue with our latest release version?

Can you reproduce the issue with the latest code from main?

Are you using the demo app or your own custom app?

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?

What did you do?

What did you expect to happen?

What actually happened?

@sundip111 sundip111 added the type: bug Something isn't working correctly label Aug 19, 2022
@sundip111 sundip111 reopened this Aug 19, 2022
@sundip111 sundip111 changed the title Empty Segmented VTT captions Captions stops renering after it hits the EMPTY Segmented VTT captions file Aug 19, 2022
@github-actions github-actions bot added this to the v4.3 milestone Aug 19, 2022
@sundip111
Copy link
Author

sundip111 commented Aug 19, 2022

Background:
I am developing a Chromecast custom receiver and captions are being rendered using segmented VTT. I ran into an issue when at some point one of the segments returned an empty response for a certain time slot. And captions stopped being rendered on the player.

Findings so far:
One of our backend devs found that the error is being thrown from - mp4_vtt_parser and if we add a check if (!data.length) return []; here https://github.com/shaka-project/shaka-player/blob/main/lib/text/mp4_vtt_parser.js#L100` can solve the issue.

Looking for some advise here. Thank you in advance.

@joeyparrish
Copy link
Member

So by "empty", it seems that you mean the segment itself is 0-bytes? That feels like a content problem. That segment isn't a valid mp4 file, so of course it is rejected by the mp4 parser.

Is there some reason you won't or can't fix your broken backend?

@joeyparrish joeyparrish added status: bad content Caused by invalid, broken, or unsupported content component: captions/subtitles The issue involves captions or subtitles component: WebVTT The issue involves WebVTT subtitles specifically labels Aug 19, 2022
@sundip111
Copy link
Author

Thanks, @joeyparrish for the quick response.

Correct, our backend team is looking into this, however, is that possible to handle this scenario by adding the check on the method itself to avoid the missing captions?

@joeyparrish
Copy link
Member

Sure, that could work.

@avelad avelad modified the milestones: v4.3, v4.4 Nov 11, 2022
@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including @shaka-bot reopen in a comment.

@github-actions github-actions bot closed this as completed Feb 6, 2023
@github-actions github-actions bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Feb 6, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Apr 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: WebVTT The issue involves WebVTT subtitles specifically status: archived Archived and locked; will not be updated status: bad content Caused by invalid, broken, or unsupported content type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants