Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EME Editor's Draft Incompatibilities #45

Closed
dansanders opened this issue Mar 31, 2015 · 3 comments
Closed

EME Editor's Draft Incompatibilities #45

dansanders opened this issue Mar 31, 2015 · 3 comments
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v1.3.0

Comments

@dansanders
Copy link

EmeManager creates configurations that are not compatible with the current EME Editor's Draft. In particular, it can create empty lists for initDataTypes, audioCapabilities, and videoCapabilities; these are rejected in the current draft. If there are no requirements, the members should not be present in the configuration dictionary at all.

Somewhat trickier is that sessionTypes must now be specified for createSession() to operate. This isn't necessary if only "temporary" sessions are created, but Shaka will try to create "persistent-license" sessions without asking for them.
@dansanders
Copy link
Author

It's worth noting that the ideal behavior is to always fill in these lists, since it is not a good user experience to fail to play media after calling requestMediaKeySystemAccess(). (requestMediaKeySystemAccess() could initiate a user prompt or download a CDM, for example.)

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Apr 1, 2015
@joeyparrish joeyparrish added this to the v1.3.0 milestone Apr 1, 2015
@joeyparrish joeyparrish self-assigned this Apr 1, 2015
@joeyparrish
Copy link
Member

Reproduced in Chrome 43.0.2353.0.

@joeyparrish
Copy link
Member

Tested working in Chrome 41, 42, and 43.

@joeyparrish joeyparrish mentioned this issue Apr 7, 2015
Closed
joeyparrish added a commit that referenced this issue Apr 7, 2015
@joeyparrish
Leave unused MKSC fields undefined.
8b20bef 
This fixes EME draft spec compliance issues.

Closes #45.

(Issue #45, back-ported to v1.2.x branch)

Change-Id: Ida55d5a14da03acdc0120fb5946c33ab42d800c3
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
4 participants
@TheModMaker @joeyparrish @dansanders @shaka-bot