Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cea608 TypeError preventing playback #4508

Closed
mamaddox opened this issue Sep 23, 2022 · 2 comments · Fixed by #4510 or #4424
Closed

Cea608 TypeError preventing playback #4508

mamaddox opened this issue Sep 23, 2022 · 2 comments · Fixed by #4510 or #4424
Assignees
@mamaddox
Labels
component: captions/subtitles The issue involves captions or subtitles flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.3

Comments

@mamaddox
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
v4.2.1

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Custom environment

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Chrome 105.0.5195.125 on MacOS Catalina 10.15.7

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

Stream Fragment causing the issue:
https://s3.amazonaws.com/playertest.longtailvideo.com/cea608-error/master.mpd
(Can send the full stream as well if needed).

What configuration are you using? What is the output of player.getConfiguration()?

What did you do?

Attempted to play the above stream and got a TypeError error instead.
In case there is an issue with the stream, if it's a non-fatal issue, I think the player should be able to recover.

What did you expect to happen?
Stream should play without error

What actually happened?

Get a TypeError about not being able to ('map') of undefined
Screen Shot 2022-09-22 at 10 02 12 AM
@mamaddox mamaddox added the type: bug Something isn't working correctly label Sep 23, 2022
@github-actions github-actions bot added this to the v4.3 milestone Sep 23, 2022
@mamaddox
Copy link
Contributor Author

I am working on a PR for this. It looks like moveRows is being passed a negative row index for some reason, so it's trying to call map on a row that doesn't exist.

@avelad
Copy link
Collaborator

avelad commented Sep 23, 2022

Thanks @mamaddox , I'll assign to you the issue!

@avelad avelad added flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release labels Sep 23, 2022
@mamaddox mamaddox mentioned this issue Sep 23, 2022
Merged
avelad pushed a commit that referenced this issue Sep 27, 2022
@mamaddox
fix: check for negative rows before moving (#4510)
b3621c2 
Closes #4508
@github-actions github-actions bot mentioned this issue Sep 27, 2022
Merged
JulianDomingo pushed a commit that referenced this issue Oct 6, 2022
@mamaddox @JulianDomingo
fix: check for negative rows before moving (#4510)
23f39d7 
Closes #4508
@github-actions github-actions bot mentioned this issue Oct 6, 2022
Merged
JulianDomingo pushed a commit that referenced this issue Oct 6, 2022
@mamaddox @JulianDomingo
fix: check for negative rows before moving (#4510)
31abae3 
Closes #4508
@github-actions github-actions bot mentioned this issue Oct 6, 2022
Merged
JulianDomingo pushed a commit that referenced this issue Oct 7, 2022
@mamaddox @JulianDomingo
fix: check for negative rows before moving (#4510)
359b63e 
Closes #4508
@github-actions github-actions bot mentioned this issue Oct 7, 2022
Merged
JulianDomingo pushed a commit that referenced this issue Oct 7, 2022
@mamaddox @JulianDomingo
fix: check for negative rows before moving (#4510)
12e3305 
Closes #4508
@github-actions github-actions bot mentioned this issue Oct 7, 2022
Merged
JulianDomingo pushed a commit that referenced this issue Oct 7, 2022
@github-actions
chore(v3.2.x): release 3.2.13 (#4557)
16ba6cd 
🤖 I have created a release *beep* *boop*
---


##
[3.2.13](v3.2.12...v3.2.13)
(2022-10-07)


### Bug Fixes

* allow build without text
([#4506](#4506))
([5f3afd4](5f3afd4))
* allow the playback on platforms when low latency APIs are not
supported
([#4485](#4485))
([0239aa5](0239aa5))
* check for negative rows before moving
([#4510](#4510))
([12e3305](12e3305)),
closes
[#4508](#4508)
* Filter unsupported H.264 streams in Xbox
([#4493](#4493))
([ea02766](ea02766))
* Fix hang when seeking to the last segment
([#4537](#4537))
([951aaea](951aaea))
* Respect existing app usage of Cast SDK
([#4523](#4523))
([da5fd15](da5fd15)),
closes
[#4521](#4521)
* **ttml:** Default TTML background color to transparent if unspecified
([#4496](#4496))
([0c6ad6d](0c6ad6d)),
closes
[#4468](#4468)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JulianDomingo pushed a commit that referenced this issue Oct 7, 2022
@github-actions
chore(v3.3.x): release 3.3.11 (#4556)
791041b 
🤖 I have created a release *beep* *boop*
---


##
[3.3.11](v3.3.10...v3.3.11)
(2022-10-07)


### Bug Fixes

* allow build without text
([#4506](#4506))
([5014c1d](5014c1d))
* allow the playback on platforms when low latency APIs are not
supported
([#4485](#4485))
([c0fc0b4](c0fc0b4))
* check for negative rows before moving
([#4510](#4510))
([359b63e](359b63e)),
closes
[#4508](#4508)
* Filter unsupported H.264 streams in Xbox
([#4493](#4493))
([21ee94f](21ee94f))
* Fix hang when seeking to the last segment
([#4537](#4537))
([2868e12](2868e12))
* Respect existing app usage of Cast SDK
([#4523](#4523))
([d2258d6](d2258d6)),
closes
[#4521](#4521)
* **ttml:** Default TTML background color to transparent if unspecified
([#4496](#4496))
([862ee42](862ee42)),
closes
[#4468](#4468)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JulianDomingo pushed a commit that referenced this issue Oct 7, 2022
@github-actions
chore(v4.1.x): release 4.1.5 (#4555)
3279ad4 
🤖 I have created a release *beep* *boop*
---


##
[4.1.5](v4.1.4...v4.1.5)
(2022-10-07)


### Bug Fixes

* allow build without text
([#4506](#4506))
([1db6265](1db6265))
* allow the playback on platforms when low latency APIs are not
supported
([#4485](#4485))
([55d1390](55d1390))
* check for negative rows before moving
([#4510](#4510))
([31abae3](31abae3)),
closes
[#4508](#4508)
* Filter unsupported H.264 streams in Xbox
([#4493](#4493))
([1ecede6](1ecede6))
* Fix choppy HLS startup
([#4553](#4553))
([1675bff](1675bff)),
closes
[#4516](#4516)
* Fix errors with TS segments on Chromecast
([#4543](#4543))
([15a1c60](15a1c60))
* Fix hang when seeking to the last segment
([#4537](#4537))
([72a119d](72a119d))
* Fix HLS dynamic to static transition
([932d37c](932d37c))
* Fix HLS dynamic to static transition
([#4483](#4483))
([932d37c](932d37c)),
closes
[#4431](#4431)
* Fix in-band key rotation on Xbox One
([#4478](#4478))
([5a8f09c](5a8f09c)),
closes
[#4401](#4401)
* Respect existing app usage of Cast SDK
([#4523](#4523))
([9c3a494](9c3a494)),
closes
[#4521](#4521)
* **ttml:** Default TTML background color to transparent if unspecified
([#4496](#4496))
([16da1e7](16da1e7)),
closes
[#4468](#4468)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JulianDomingo pushed a commit that referenced this issue Oct 7, 2022
@github-actions
chore(v4.2.x): release 4.2.2 (#4554)
cf836a4 
🤖 I have created a release *beep* *boop*
---


##
[4.2.2](v4.2.1...v4.2.2)
(2022-10-07)


### Bug Fixes

* allow build without text
([#4506](#4506))
([7e93720](7e93720))
* allow the playback on platforms when low latency APIs are not
supported
([#4485](#4485))
([cf8c857](cf8c857))
* check for negative rows before moving
([#4510](#4510))
([23f39d7](23f39d7)),
closes
[#4508](#4508)
* Filter unsupported H.264 streams in Xbox
([#4493](#4493))
([914a08a](914a08a))
* Fix choppy HLS startup
([#4553](#4553))
([950ce69](950ce69)),
closes
[#4516](#4516)
* Fix errors with TS segments on Chromecast
([#4543](#4543))
([8204db6](8204db6))
* Fix hang when seeking to the last segment
([#4537](#4537))
([3d6c768](3d6c768))
* Fix HLS dynamic to static transition
([d9ecbf3](d9ecbf3))
* Fix HLS dynamic to static transition
([#4483](#4483))
([d9ecbf3](d9ecbf3)),
closes
[#4431](#4431)
* Fix in-band key rotation on Xbox One
([#4478](#4478))
([bc0a588](bc0a588)),
closes
[#4401](#4401)
* Missing AES-128 key of last HLS segment
([#4519](#4519))
([2c2677f](2c2677f)),
closes
[#4517](#4517)
* Respect existing app usage of Cast SDK
([#4523](#4523))
([3db2568](3db2568)),
closes
[#4521](#4521)
* **ttml:** Default TTML background color to transparent if unspecified
([#4496](#4496))
([0b5c985](0b5c985)),
closes
[#4468](#4468)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Nov 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mamaddox mamaddox

Labels
component: captions/subtitles The issue involves captions or subtitles flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.3
2 participants
@avelad @mamaddox