Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bufferBehind is being overridden by image adaptation set's segment duration #4717

Closed
littlespex opened this issue Nov 16, 2022 · 0 comments · Fixed by #4718
Closed

bufferBehind is being overridden by image adaptation set's segment duration #4717

littlespex opened this issue Nov 16, 2022 · 0 comments · Fixed by #4718
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@littlespex
Copy link
Collaborator

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
4.2.x

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Chrome macOs

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
WebKit Foxtel

What are the manifest and license server URIs?

Available upon request

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

Load a manifest that has an image adaptation set containing a SegmentTemplate with a duration larger than 60 (the default bufferBehind value).

What did you expect to happen?
The value of bufferBehind should be 60, or what ever value was passed in through the config.

What actually happened?

The value is the duration of the image segment template. While this is expected behavior if a video or audio segment's duration is longer than the configured value, we don't expect image adaptations to apply as they don't actually use the buffer.

@littlespex littlespex added the type: bug Something isn't working correctly label Nov 16, 2022
@github-actions github-actions bot added this to the v4.4 milestone Nov 16, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jan 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant