Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor streaming and adaptation #51

Closed
joeyparrish opened this issue Apr 7, 2015 · 0 comments
Closed

Refactor streaming and adaptation #51

joeyparrish opened this issue Apr 7, 2015 · 0 comments
Labels
status: archived Archived and locked; will not be updated type: code health A code health issue type: enhancement New feature or request
Milestone
v1.4.0

Comments

@joeyparrish
Copy link
Member

We should refactor start-up in such a way that we can resolve segment indices for all representations before our first adaptation. This should be done without negatively impacting start-up latency. This will allow for further refactoring and improvement of adaptation mechanisms.
@joeyparrish joeyparrish added type: enhancement New feature or request type: code health A code health issue labels Apr 7, 2015
@joeyparrish joeyparrish modified the milestone: v1.4.0 Apr 7, 2015
joeyparrish added a commit that referenced this issue Apr 7, 2015
@joeyparrish
Clean up Stream constants.
ffb4220 
Drop unused SWITCH_BUFFER_SIZE_SECONDS_ and combine
SINGLE_FRAME_SECONDS_ and the unnamed nudge constant into NUDGE_.

Issue #51.

Change-Id: I5d9a001aa6432a859b6205ded6e1d75be759b9db
joeyparrish added a commit that referenced this issue Apr 14, 2015
@joeyparrish
Refactor minBufferTime and bufferingGoal.
10f80d2 
Strip extraneous minBufferTime copies.
Default minBufferTime in MpdProcessor if missing.
Pass minBufferTime as a parameter to Stream.start().
Keep a buffering goal separate from minBufferTime, which will only
be used for stream startup (as intended by the DASH spec).

This allows us to startup quickly and still buffer ahead.

Relates to #51.

Change-Id: I94b6b2566419344fa761ff75b0884719f255cd66
joeyparrish added a commit that referenced this issue Apr 14, 2015
@joeyparrish
Schedule the switch in the video timeline.
55e25d1 
Instead of always replacing the currentTime, only replace starting
at the currentTime for immediate switches.  Otherwise, use bandwidth
estimates to guess what the video currentTime will be when the new
segments have been fetched, and replace the old segments starting
at that point.

Relates to #51.

Change-Id: I0e8546402cb0f7a007a6c210ed3b215c8379e236
@tdrews tdrews self-assigned this Jun 1, 2015
@joeyparrish joeyparrish mentioned this issue Jun 9, 2015
Closed
allenevans referenced this issue in blinkbox/shaka-player Jun 17, 2015
@allenevans
Allow initial stream buffer size to be runtime configurable.
4d6ddde
This was referenced Jun 17, 2015
Closed
Closed
tdrews pushed a commit that referenced this issue Jun 19, 2015
Re-work stream switching.
fbea227 
* Allow segments from different streams (Representations) to coexist
  in buffer.
* Only fetch a single segment at a time.
* Remove id field from SegmentReference and remove SegmentRange.
* Only start the Streams once the buffer is "full".
* Stop DashVideoSource from triggering an extra resync during startup.
* Make Task.abort call order deterministic.

A follow-up patch is required to handle certain seek patterns in
live streams.

Issue #51

Change-Id: Ib7c9021471f1ed89323f19764463202b119cb491
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: code health A code health issue type: enhancement New feature or request
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
4 participants
@TheModMaker @joeyparrish @tdrews @shaka-bot